[Cherry-Pick][RL] Reuse GDR checkpoint transfer handle(#8078)#8079
Conversation
6ae8098 to
4b77ebf
Compare
PaddlePaddle-bot
left a comment
There was a problem hiding this comment.
🤖 Paddle-CI-Agent | pr_review |
2026-06-25 20:03:04
📋 Review 摘要
PR 概述:为 RL 动态权重更新的 GDR 路径缓存并复用 CheckpointTransfer handle。
变更范围:fastdeploy/rl/dynamic_weight_manager.py、tests/rl/test_dynamic_weight_gdr.py
影响面 Tag:[RL]
问题
未发现阻塞性问题。PR 规范问题在下面章节报,不要在这里重复
历史 Findings 修复情况
| Finding | 问题 | 状态 |
|---|---|---|
| F1 | _destroy_gdr_handle 会静默吞掉 cleanup 失败。 |
📝 PR 规范检查
不符合规范:当前标题 [Cherry-Pick][RL] Reuse GDR checkpoint transfer handle 缺少 release 分支 Cherry-Pick 标题要求的来源 develop PR 号,规范格式为 [Cherry-Pick][Tag] 标题描述(#原PR号)。当前上下文和本地 git 历史没有可验证的来源 PR 号,因此不臆造编号;请补齐真实来源 PR 号后使用该格式。PR 描述已包含 Motivation、Modifications、Usage or Command、Accuracy Tests、Checklist,结构符合 §D2。
总体评价
代码实现和新增单测覆盖了 handle 复用及失败后重建的主要路径;未发现新的阻塞性代码问题。历史 cleanup 异常静默问题仍保留,建议后续至少记录日志以便排障。
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/2.6 #8079 +/- ##
==============================================
Coverage ? 71.60%
==============================================
Files ? 386
Lines ? 55790
Branches ? 8764
==============================================
Hits ? 39951
Misses ? 13023
Partials ? 2816
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
82c7c7a
into
PaddlePaddle:release/2.6
Motivation
Avoid repeated
CheckpointTransferinitialization during GDR dynamic weight updates. Reusing the initialized handle reduces repeated setup overhead across multiple update steps.Modifications
CheckpointTransferhandle inDynamicWeightManager.update_weights_by_gdrcalls.Usage or Command
No new user-facing command. Existing GDR weight update flow is unchanged.
Accuracy Tests
Not applicable. This PR only changes checkpoint-transfer handle initialization behavior and does not affect model outputs.
Checklist
pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.