Log failed library downloads in MavenLibraryResolver - #14200
Open
CJH3139 wants to merge 1 commit into
Open
Conversation
electronicboy
approved these changes
Aug 22, 2026
Warriorrrr
requested changes
Aug 24, 2026
Warriorrrr
left a comment
Warriorrrr
left a comment
Member
There was a problem hiding this comment.
This will become incredibly spammy the moment you start adding multiple repositories to it, since it has to query possibly all repositories to find the one containing the artifacts you'd get a lot of noise for something that ended up being successful. I think it'd be best to see if it's possible to limit it to 5XX/429 types of responses like the original issue said, and only log the exception message instead of the full stacktrace.
github-project-automation
Bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12638