Fire PrePlayerAttackEntityEvent for entities hit by sweep attacks - #14203
Open
TFSMads wants to merge 1 commit into
Open
Fire PrePlayerAttackEntityEvent for entities hit by sweep attacks#14203TFSMads wants to merge 1 commit into
TFSMads wants to merge 1 commit into
Conversation
1 task
Member
|
This is not a proper call for this event. This event is meant to be called when attacking a specific player. A separate event should be added. As this would be then applicable to entities jabbed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
PrePlayerAttackEntityEventis only fired for the entity that is directly attacked by a player. Entities subsequently hit by a sword sweep attack do not receive the event.This PR adds
PrePlayerAttackEntityEventcalls for entities affected by a sweep attack when the direct damage source is a player.For each nearby entity affected by the sweep attack, the event is created with the attacking player and the entity being hit. If the event is cancelled, the entity is skipped and does not receive the sweep attack damage.