RabbitMQ: Only set the AuthMechanisms when UseExternalAuthMechanism is set to true#5416
Merged
danielmarbach merged 1 commit intomasterfrom Apr 13, 2026
Merged
RabbitMQ: Only set the AuthMechanisms when UseExternalAuthMechanism is set to true#5416danielmarbach merged 1 commit intomasterfrom
danielmarbach merged 1 commit intomasterfrom
Conversation
mauroservienti
approved these changes
Apr 13, 2026
ramonsmits
reviewed
Apr 13, 2026
| } | ||
|
|
||
| if (dictionary.TryGetValue("UseExternalAuthMechanism", out var useExternalAuthMechanismString)) | ||
| if (dictionary.TryGetValue("UseExternalAuthMechanism", out var useExternalAuthMechanismString) && bool.TryParse(useExternalAuthMechanismString, out var useExternalAuthMechanism) && useExternalAuthMechanism) |
Member
There was a problem hiding this comment.
If parsing fails, there should be an exception as that means there was a typo unless the values in the dictionary have already been format validated.
Contributor
Author
There was a problem hiding this comment.
The rest of the code uses TryParse too. I'm trying to make a minimal fix here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: