Skip to content

Combine push-nuget-packages staging workflow and production action. - #4

Open
ngallegos wants to merge 4 commits into
nuget-trusted-publishing-actionfrom
combine-push-nuget-package-steps
Open

ngallegos wants to merge 4 commits into
nuget-trusted-publishing-actionfrom
combine-push-nuget-package-steps

Conversation

@ngallegos

Copy link
Copy Markdown
Collaborator

No description provided.

@ngallegos
ngallegos added this pull request to stack #5 September 24, 2026 23:10
@ngallegos
ngallegos force-pushed the combine-push-nuget-package-steps branch from 803d6a5 to dafe10e Compare September 30, 2026 19:37
@ngallegos
ngallegos force-pushed the combine-push-nuget-package-steps branch from dafe10e to c694275 Compare September 30, 2026 21:32
Comment thread .github/actions/push-nuget-packages/action.yml Outdated
if: inputs.publish-mode == 'trusted-publishing'
shell: pwsh
run: |
$domain = ([Uri]"${{ inputs.feed-url }}").GetLeftPart([System.UriPartial]::Authority)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: fancy!

token-service-url: ${{ inputs.nuget-source-domain }}/api/v2/token
audience: ${{ inputs.nuget-source-domain }}
- name: Push NuGet packages to production feed
token-service-url: ${{ steps.resolve.outputs.domain }}/api/v2/token

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: I don't recall if I asked this, but why do we use v2 instead of v3?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just going off of what the default was: https://github.com/NuGet/login#-inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants