☀️ 73% – adopt seventy-eight exact owners on 2338f8f0a: ten main-image functions and sixty-eight scene sequences

[wowwheaties]

Summary

One commit on claude/75-percent-coverage-m7axsj (2338f8f): 78 owners adopted at differing_halfwords=0 that this branch does not have — 68 overlay scene sequences and 10 main-image functions. README 72.49% → 73.10%.

This is PR #6 reduced to what remains unique after this branch's own harvest: the 92 owners both sides reached were dropped here (91 at ecb525b plus resource_3a8:02003768 adopted at 949ce3c) (your versions stay), leaving the 78 this branch still carries as retained assembly or name-only registrations.

Every overlay owner was re-adopted on this tip through this branch's own thumb2c adopt <owner> --span <registered span> --source <file> --name <name>; the 11 main-image functions carry #define Subsystem_VerbObject Func_<address> aliases and register under semantic names (Graphics_CopyRectKeepLow, SaveState_LoadSelectedSlot, Menu_RunResourceModePrompt, Map_GetFocusedObjectTile, Map_FindMatchingTrigger, BattleEffect_Dispatch, PsynergyMenu_DrawVisibleActionPage, InventoryMenu_ShowModalMessage, Shop_SelectPartyMemberItem, BattlePresentation_BuildOpponentEntries, MusicPlayer_SetPitchAndUpdateFrequency), their games/gs1/asm/<addr>.s and recon drafts retired.

Registry notes:

• Retained overlay-assembly regions around the adopted owners that sat inside them retained overlay-assembly regions were shortened or cloned around adopted owners that sat inside them (evidence line appended on each), the same edit as in ☀️ 74% – adopt seventy-four exact owners on 7d8a72083: eight main-image functions and sixty-six scene sequences #6.
• Five owners took the next free sequence letter because this branch already uses the letter for a different owner in the same overlay: resource_372:0200173c →SequenceF, resource_373:020010d8 →SequenceF, resource_37b:02000614 →SequenceB, resource_37f:020017c0 →SequenceB, resource_3bf:02000d54 →SequenceE.
• Name-only RunEventScript registrations wholly inside adopted owners were absorbed by thumb2c adopt as before.

Gates (on 2338f8f)

• make overlay-check: audited rows with findings: 0
• make full-rom-check: byte_identical=yes, unowned_bytes=0
• make build-claimed, make build-asm, make coverage, make verify: green

Compiler note (early literal pools)

Several large scene functions match instruction-for-instruction but the ROM dumps a literal pool much earlier than the SImode range requires (b.n over a mid-function pool). Reading gcc/config/arm/arm.c (push_minipool_fix, create_fix_barrier) and arm.md: the pool head is the tightest fix, and *thumb_movhi_insn alt 1 / *thumb_zero_extendhisi2 carry pool ranges of 64 / 60 bytes. A plain u16 local is promoted to SImode, so the ordinary-C spellings that reproduce the ROM are a one-element array for a constant used as a value — u16 p[1]; p[0] = (u16)(s32)Data_00000000; — and the bare 16-bit constant for a u16 store (*shown = 0xe00; rather than (u16)(s32)Data_00000e00). This made resource_3c9:0200423c and resource_3c9:020008b4 exact here and moved four others to within a handful of halfwords; the converter could emit it for HImode pool fixes.

Near-exact drafts (not adopted; residue is allocation or scheduling only)

Available on request as seeds for your queue, each scored at its registered span: resource_373:020015dc 5240 B dh 10, resource_380:020027f8 5932 B dh 28, resource_3a4:02001838 1236 B dh 20, resource_371:020039fc 1296 B dh 66, resource_371:020028e8 972 B dh 19, resource_3af:020022c0 856 B dh 26, resource_3b1:02004254 892 B dh 2, resource_383:02001348 1608 B dh 2, resource_380:02001d04 1400 B dh 6, resource_377:02000a0c 1064 B dh 16, resource_3b9:02000dcc 992 B dh 6, resource_39f:02002500 dh 4 at 1700 B (its registered span of 1640 stops 60 bytes before the pool).

Review notes

• Compiler here is an Ubuntu 24.04 host rebuild of the pinned alchemy-gcc (dist hash f9086851…, distinct from the a3c3cfd9… rebuild this branch admits); the full ROM is byte-identical locally. Please re-verify with your bundle.
• Built on 2338f8f; a rebase onto a newer tip is mechanical — say the word.
• ☀️ 74% – adopt seventy-four exact owners on 7d8a72083: eight main-image functions and sixty-six scene sequences #6 stays open against main until this lands; I will close it in favour of this one.

🤖 Generated with Claude Code