Skip to content

Add martial artist rune slots#1991

Open
vaisest wants to merge 15 commits into
PathOfBuildingCommunity:devfrom
vaisest:martial-artist-runes
Open

Add martial artist rune slots#1991
vaisest wants to merge 15 commits into
PathOfBuildingCommunity:devfrom
vaisest:martial-artist-runes

Conversation

@vaisest
Copy link
Copy Markdown
Contributor

@vaisest vaisest commented May 27, 2026

Description of the problem being solved:

This adds runic meridians support by:

  • importing runes from json
  • adding dropdown controls (which primarily save the rune name, no dummy items created so not an ItemSlotControl)
  • saving runes to weapon sets
  • saving and loading them in builds

Steps taken to verify a working solution:

  • testing with monk builds from poe.ninja
  • playing with my own character which is not a monk (nothing has broken)

Link to a build that showcases this PR:

https://poe.ninja/poe2/builds/runesofaldur/character/heygyus-0416/ResurrectGodAura?i=0&search=class%3DMartial%2BArtist

After screenshot:

image image

@vaisest vaisest force-pushed the martial-artist-runes branch 2 times, most recently from 786c227 to 9132caf Compare May 28, 2026 22:37
Comment thread src/Modules/ModParser.lua
["you can socket (%d+) additional copies of each lineage support gem, in different skills"] = function(num) return { mod("MaxLineageCount", "BASE", num) } end,
["can be modified while corrupted"] = {}
["can be modified while corrupted"] = {},
["can tattoo runes onto your body, gaining"] = { flag("SocketRunesOnCharacter") },
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure if this is the correct way to do this. It would probably be possible to parse the socket counts, but this seems much simpler

@vaisest vaisest force-pushed the martial-artist-runes branch from 8fa5a4a to e6be088 Compare June 1, 2026 15:27
@vaisest
Copy link
Copy Markdown
Contributor Author

vaisest commented Jun 1, 2026

Rebased to dev. This seems to work fine, except it seems dev has outdated data exports and that causes confusing errors after re-exporting here. I think the test failure might be unrelated to this, but I might also be clueless

Edit: I am clueless: edit exports were caused by me not pressing ctrl+f5 to re-export game data. This should be fine now

@vaisest vaisest marked this pull request as ready for review June 1, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant