Fix crash on trying to use Trarthan Cannon#2048
Open
LocalIdentity wants to merge 1 commit into
Open
Conversation
We assumed that all crossbows would have the reload time stats but this new base type doesn't have it Added checks to CalcOffence to make sure that value exists now Also add proper support for the weapon implicit so all ammo skills can't be used with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2047
Description of the problem being solved:
We assumed that all crossbows would have the reload time stats but this new base type doesn't have it
Added checks to CalcOffence to make sure that value exists now
Also add proper support for the weapon implicit so all ammo skills can't be used with it
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/wh71yh0y
Before screenshot:
After screenshot: