Add support for additional Warcry Empowers#2071
Merged
LocalIdentity merged 2 commits intoJun 3, 2026
Merged
Conversation
add breakdown for # of empowered attacks
Peechey
changed the title
Also removes the condition check as it meant that infernal cry damage would only apply if you ticked the config box
LocalIdentity
approved these changes
Jun 3, 2026
Contributor
LocalIdentity
left a comment
LocalIdentity
left a comment
There was a problem hiding this comment.
I fixed it so that the average empowers didnt floor to the nearest int as it would not work properly with the new chance to empower x mod
Also removed the condition check for empower as it made the fire damage not apply unless you ticked the config option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for "Warcries Empower an additional Attack" and "Warcries have 15% chance to Empower 3 additional Attacks".
Updating Infernal Cry to use NumInfernalEmpowers from CalcPerform instead of doing the (now outdated) math in CalcOffense. To do so, I'm changing the UsesWarcryPower flag to be a Warcry globalEffect instead of Buff so we run the CalcPerform code. We don't have to do this is in PoB1 because the warcry buff was a globalEffect Warcry scaled by Power, but in PoE2, Power determines the number of empowered attacks and the buff is scaled by overall uptime. So things are moved around a little. Ultimately we just need to run the warcry code in perform at some point and this seemed good.
Added a breakdown to # of Empowered.
Link to a build that showcases this PR:
After screenshot:
--