Fix some bonded Rune affects applying without Wisdom of the Maji#2076
Merged
Conversation
The logic for combining Rune stats on gear wasn't check to see if a mod was bonded before merging the stat We now use a separate key so they no longer merge with each other but will merge correctly with other rune mods of the same type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2051
Description of the problem being solved:
The logic for combining Rune stats on gear wasn't check to see if a mod was bonded before merging the stat
We now use a separate key so they no longer merge with each other but will merge correctly with other rune mods of the same type
Before screenshot:
After screenshot: