Skip to content

Fix Shrine sceptre Auras not making linked buffs have no Spirit cost #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Jun 3, 2026
Merged

Fix Shrine sceptre Auras not making linked buffs have no Spirit cost #2077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions spec/System/TestSkills_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,13 @@ describe("TestSkills", function()
assert.True(build.calcsTab.mainOutput.SpiritReservedPercent > oneCurseReservation)
end)

it("applies active skill reservation multiplier to linked buff spirit reservation", function()
build.skillsTab:PasteSocketGroup("Purity of Fire 20/0 1\nVitality II 1/0 1\n")
runCallback("OnFrame")

assert.are.equals(0, build.calcsTab.mainOutput.SpiritReserved)
end)

it("Keeps Virtuous armour scaling during Full DPS loop", function()
build.itemsTab:CreateDisplayItemFromRaw("New Item\nRazor Quarterstaff\nQuality: 0")
build.itemsTab:AddDisplayItem()
Expand Down
3 changes: 3 additions & 0 deletions src/Modules/CalcActiveSkill.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,9 @@ function calcs.buildActiveSkillModList(env, activeSkill)

-- Add extra modifiers from granted effect level
local level = activeEffect.grantedEffectLevel
if level.reservationMultiplier then
skillModList:NewMod("ReservationMultiplier", "MORE", level.reservationMultiplier, activeGrantedEffect.modSource)
end
activeSkill.skillData.CritChance = level.critChance
if level.damageMultiplier then
skillModList:NewMod("Damage", "MORE", level.damageMultiplier, activeEffect.grantedEffect.modSource, ModFlag.Attack)
Expand Down
Loading