Add support for Baryanic Leylines notable#2381
Open
jacul wants to merge 1 commit into
Open
Conversation
Parses "Non-Unique Time-Lost Jewels have 40% increased radius" and applies it to socketed non-unique Time-Lost jewels. Adds 40% increased versions of the four base radii to data.jewelRadius. PassiveSpec:GetJewelRadiusIndex() now remaps Time-Lost jewel's index to the new versions when the notable is allocated. The lookup goes through the spec instead of the item, so loadouts and tree compare can disagree for the same jewel. Tree view rings, hover previews, and tooltips are updated to use the effective index. ModCache is also regenerated for the new parser entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parses "Non-Unique Time-Lost Jewels have 40% increased radius" and applies it to socketed non-unique Time-Lost jewels.
Adds 40% increased versions of the four base radii to data.jewelRadius. PassiveSpec:GetJewelRadiusIndex() now remaps Time-Lost jewel's index to the new versions when the notable is allocated. The lookup goes through the spec instead of the item, so loadouts and tree compare can disagree for the same jewel.
Tree view rings, hover previews, and tooltips are updated to use the effective index.
ModCache is also regenerated for the new parser entry.
Fixes #2380 .
Description of the problem being solved:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: