Repository navigation
use newer CONFIGURE_REQUIRES instead of clobbering - #439
Merged
Merged
Conversation
…RES version mm_args2() previously always overwrote a caller-specified CONFIGURE_REQUIRES version with its own required version, even if the caller's was higher (gh#428). Rather than simply preferring the caller's value (as proposed in gh#429), pick whichever of the two versions is newer, using a small pure-Perl comparator that supports both decimal (1.23) and dotted-decimal (1.2.3) version strings, with no non-core dependencies. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PD59r5VDdEpwo1QFVJPebY
plicease
changed the title
Wget2 (shipped as /usr/bin/wget on some newer Linux distributions, e.g. Fedora 40) does not follow the same interface as GNU Wget: its -S/verbose output goes to stdout instead of stderr, and does not reliably include the Content-Type header, which broke this plugin's HTML detection in CI (gh#439). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfmKBXbWcHypDknMmkME6B
alpine3.20.1's pkgconf-dev is pkgconf 2.2.0, which changed the pkgconf_pkg_new_from_file() signature in libpkgconf, breaking the XS build of PkgConfig::LibPkgConf 0.11 (gh#439). The corresponding test already skips cleanly when the module isn't installed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfmKBXbWcHypDknMmkME6B
plicease
deleted the
graham/do-not-clobber-configure-requires-in-abw
branch
September 12, 2026 02:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…RES version
mm_args2() previously always overwrote a caller-specified CONFIGURE_REQUIRES version with its own required version, even if the caller's was higher (gh#428). Rather than simply preferring the caller's value (as proposed in gh#429), pick whichever of the two versions is newer, using a small pure-Perl comparator that supports both decimal (1.23) and dotted-decimal (1.2.3) version strings, with no non-core dependencies.
Claude-Session: https://claude.ai/code/session_01PD59r5VDdEpwo1QFVJPebY