Skip to content

VSP-1844 [iOS] Stela Migration: Migrate Remaining Folder Metadata Reads to V2 (GET /v2/folders) - #591

Open
luciancerbu-vsp wants to merge 1 commit into
feature/migration-to-Stela-V2from
feature/VSP-1844-iOS-Stela-Migration-Migrate-Remaining-Folder-Metadata-Reads-to-V2
Open

VSP-1844 [iOS] Stela Migration: Migrate Remaining Folder Metadata Reads to V2 (GET /v2/folders)#591
luciancerbu-vsp wants to merge 1 commit into
feature/migration-to-Stela-V2from
feature/VSP-1844-iOS-Stela-Migration-Migrate-Remaining-Folder-Metadata-Reads-to-V2

Conversation

@luciancerbu-vsp

Copy link
Copy Markdown
Contributor
  • Shared-folder role badge reads GET /api/v2/folders?folderIds[]= first, via the new FolderV2Data.accessRole. V1 folder/get stays as the failsafe.
  • getFolderById now sends the required pageSize. Without it the server answered 400 and every caller fell back to V1.
  • Shares screen loads its list once per open, always gets its callback, and each screen owns its own spinner.
  • DownloadManagerGCD.getFolder stays on V1 until a FolderV2DataFolderVO adapter exists. Follow-up.

 - Send pageSize on folder-by-id reads
 - Load Shares once and give each screen its own spinner

@sergiu-tnv sergiu-tnv left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants