VSP-1844 [iOS] Stela Migration: Migrate Remaining Folder Metadata Reads to V2 (GET /v2/folders) - #591
Open
luciancerbu-vsp wants to merge 1 commit into
Conversation
- Send pageSize on folder-by-id reads - Load Shares once and give each screen its own spinner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /api/v2/folders?folderIds[]=first, via the newFolderV2Data.accessRole. V1folder/getstays as the failsafe.getFolderByIdnow sends the requiredpageSize. Without it the server answered 400 and every caller fell back to V1.DownloadManagerGCD.getFolderstays on V1 until aFolderV2Data→FolderVOadapter exists. Follow-up.