feat(windows): complete WinUI 3 backend - #8722
Closed
proggeramlug wants to merge 2 commits into
Closed
Conversation
|
Warning Review limit reachedNext included review available in 57 seconds. View limit detailsLimit details: You’ve used all 8 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (289)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Holding this one — not on correctness, but because the gate failures need policy decisions about vendored third-party code that I don't think are mine to make unilaterally on a 73,441-line drop. Vendoring hygiene looks right, for the record: per-crate Three gates are red: 1. This one is substantive rather than cosmetic: as workspace members they enter the build graph, so 2. Generated bindings obviously shouldn't be split, so these want the script's documented 3. One that is yours, not the vendor's: 4. Note #8713 just landed (via #8721) and registers root scanners for every other UI crate, closing #8701 — if One caveat on my side: I can't validate any of the WinUI behaviour from macOS, and your test plan is |
This was referenced Aug 24, 2026
proggeramlug
added a commit
that referenced
this pull request
Aug 24, 2026
Lands #8722 with its four gate blockers resolved. Replaces the windows-winui scaffold with real WinUI 3 / Fluent rendering through a vendored Windows Reactor snapshot (microsoft/windows-rs 65066a7109c214f317ed66261cfb7518160b8aaf), upstream licenses preserved. The vendored tree moved from `crates/perry-ui-windows-winui/vendor/` to `third_party/windows-winui/`, and this was forced rather than chosen. Cargo's `is_excluded` is `!explicit_member && excluded`, and `explicit_member` matches any `members` entry that is a path PREFIX of the candidate -- so while the snapshot sat under a member directory, `exclude` lost and all 13 crates were real workspace members. Verified empirically: adding `exclude = ["crates/perry-ui-windows-winui/vendor"]` in place left cargo reporting 92 packages with all 13 still members; after the move it reports 79, matching the existing architecture baseline exactly, so no baseline refresh was needed. As members they entered the build graph, so `cargo test --workspace` compiled them and Perry's `[workspace.lints]` would have applied to upstream code. GC roots, the part that mattered: `Node` DOES hold JS values -- every widget callback is stored as a raw closure pointer via `js_nanbox_get_pointer` -- so it gets scanner coverage following #8713's pattern, not a verdict. `AppState` does not: `String`, two `f64` dimensions, an `i64` that indexes NODES rather than an address, two `Option<(f64,f64)>` and a `PresenterKind`, so it takes a `not_a_gc_pointer` verdict. Three further roots the census had not flagged are scanned too (`ON_ACTIVATE`, `ON_TERMINATE`, `PENDING_TIMERS`), and the scanner is armed on the Fluent path, where winui shadows `app_create` and would otherwise have left `perry-ui-windows`' own tables unscanned. The four oversized files are generated upstream bindings and are allowlisted as an immutable snapshot. `build_and_run.rs` was NOT allowlisted -- the block this PR added moved to `link/winui_assets.rs`, 2110 -> 1970. No version bump; the only root Cargo.toml change is the `exclude` entry. Co-authored-by: Ralph Küpper <ralph@skelpo.com>
Contributor
Author
|
Landed on The vendored tree had to move, and I verified that rather than assuming it. Cargo's On the GC side,
Two things you should know:
Validated: all 30 lint checkers, |
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windows-winuiscaffold with real WinUI 3 / Fluent rendering through a vendored Windows Reactor snapshot from microsoft/windows-rs commit 65066a7109c214f317ed66261cfb7518160b8aaf, with upstream licenses and attribution preservedTesting
cargo build --release -p perry-ui-windows-winuicargo build --release -p perry-ui-windowscargo test -p perry winui_asset_tests--target windows-winuireadyNo version bump.
Closes #4680