fix(runtime): inherit Object prototype on class instances - #8781
Merged
Conversation
Lands #8780. A registered ES class instance whose class methods and accessors all missed was excluded from the ordinary Object.prototype read fallback, so inherited reads -- `String(new C())` among them -- failed. Declared class instances do end their implicit prototype chain at Object.prototype, and their own methods are consulted before this fallback runs, so a miss must stay eligible. The exclusion now also requires the class id to be unregistered, keeping native and synthetic class ids on their existing intrinsic prototype paths. No version bump.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRegistered ES class instances now resolve inherited ChangesClass instance prototype lookup
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #8780.
A registered ES class instance whose class methods and accessors all missed was excluded from the ordinary
Object.prototyperead fallback, so inherited reads —String(new C())among them — failed. Declared class instances do end their implicit prototype chain atObject.prototype, and their own methods are consulted before this fallback runs, so a miss must remain eligible.The exclusion now additionally requires the class id to be unregistered, which keeps native and synthetic class ids on their existing intrinsic prototype paths:
Validation (on the merged result)
lint-job checkers passperry-runtime --lib(RUST_TEST_THREADS=1): 2674 passed, 0 failedperry-codegen --lib: 1230 passed, 0 failedperry-codegen --tests(all integration suites): 0 failuresThe PR carried its own
changelog.d/fragment. No version bump.Summary by CodeRabbit
Object.prototypeproperties on class instances.toStringandvalueOfbehavior, including normal string conversion for class instances.