Repository navigation
Conversation
Checks out Pi4J/pi4j (public, read-only) during the Hugo build, exports its already-curated groma.md architecture map into static/groma, and lets Hugo copy it to the site root as usual. Also reacts to a repository_dispatch sent from Pi4J/pi4j whenever architecture-relevant paths change on its main branch, so the page stays current without waiting for an unrelated push to this repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Token permissions, reproducible tool versioning, and concurrent deployment handling need correction.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Publishes Pi4J’s Groma architecture map through the existing Hugo deployment workflow.
Changes:
- Adds manual and repository-dispatch deployment triggers.
- Exports the Pi4J Groma map into Hugo static assets.
- Excludes generated map files from version control.
| File | Description |
|---|---|
.github/workflows/hugo.yml |
Adds Groma export and deployment triggers. |
.gitignore |
Ignores generated Groma assets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| repository_dispatch: | ||
| types: [groma-architecture-updated] |
There was a problem hiding this comment.
The fine-grained PAT instructions should say Contents: write for Pi4J/pi4j.github.io; Actions: write is not required for the repository_dispatch endpoint. The classic repo scope remains unchanged.
There was a problem hiding this comment.
The setup instructions are in the PR description, not a repository file. They should specify a fine-grained PAT with Contents: write for Pi4J/pi4j.github.io; Actions: write is not required for repository_dispatch. The classic PAT repo scope remains unchanged.
…ation" This reverts commit dbce325.
Add concurrency settings for GitHub Pages deployment Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
eitch
left a comment
There was a problem hiding this comment.
the serialization should be done


Summary
.github/workflows/hugo.ymlthat checks out Pi4J/pi4j (public, read-only) and runsgroma exportintostatic/gromabefore the Hugo build, so the map ends up published atpi4j.com/groma/alongside the existingv1/v2static content.repository_dispatch(groma-architecture-updated) andworkflow_dispatchtrigger, so the site can be rebuilt on demand instead of only on pushes to this repo.repository_dispatchwhenever architecture-relevant paths change on itsmainbranch — see Pi4J/pi4j#786.Requires a one-time manual step
For the automatic rebuild-on-change to work, a maintainer needs to:
reposcope).GROMA_WEBSITE_DISPATCH_TOKENin the Pi4J/pi4j repository's settings (not this one).Without that secret, this repo's own
push-to-maintrigger still works as before; the map just won't auto-refresh when only the Pi4J/pi4j code changes.Test plan
repository_dispatch🤖 Generated with Claude Code