fix: cd objective library not properly calling do_objective#3
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes CD objective startup reliability by querying rosapi action servers directly, and improves installer compatibility across Ubuntu/Debian pip versions.
Changes:
- Replaces hidden
_action/statustopic detection with/rosapi/action_servers. - Adds bounded rosapi action-server query handling with timeout behavior.
- Gates
--break-system-packagesusage ininstall.shbased on the externally-managed Python marker.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
install.sh |
Makes roslibpy installation compatible with both older pip and PEP 668 environments. |
example_scripts/cd_objective_lib.py |
Updates /do_objective readiness detection to use rosapi action-server enumeration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JWhitleyWork
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there were some issues with querying the ros
do_objectivedata that could cause hangups on running an objective, these have been fixed