Fix RGBD loading in point cloud example - #19
Merged
Conversation
Collaborator
|
LGTM |
Contributor
Author
|
Thanks for the review. I also checked the red wheel run: the only failing leg stops in the repository's existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reader.load_rgbd(True)call in the point-cloud exampleipdbbreakpoint and discardedload_both()resultrgbdaccess refers to the frame loaded by the loopAddresses #18.
Validation
uvx ruff check --no-cache --select F821 --output-format concise examples/python/generate_pcd.pyload_rgbdassignsrgbdand noipdbimport remainspython -m pytest -q -p no:cacheprovider python/tests/test_godot_depth_rgb_align.py python/tests/test_godot_spool_pack.py(16 passed, 1 skipped; the patched-FFmpeg integration test is skipped when that external environment is unavailable)A full point-cloud run was not performed because it requires a built
spatialmp4extension plus the example's Open3D runtime and suitable capture input.