Allow for autogen bypass, partial fix for #264 #252 #207, ref #303 - #347
Open
timkpaine wants to merge 1 commit into
Open
Allow for autogen bypass, partial fix for #264 #252 #207, ref #303#347timkpaine wants to merge 1 commit into
timkpaine wants to merge 1 commit into
Conversation
timkpaine
added
type: enhancement
timkpaine
force-pushed
the
tkp/autogen
branch
2 times, most recently
from
July 19, 2024 20:08
460fe5a to
b897318
Compare
timkpaine
marked this pull request as ready for review
July 19, 2024 21:14
timkpaine
requested review from
AdamGlustein,
alexddobkin,
ptomecek,
robambalu and
svatasoiu
as code owners
July 19, 2024 21:14
timkpaine
force-pushed
the
tkp/autogen
branch
3 times, most recently
from
August 8, 2024 02:10
9d3b6d0 to
6f2430e
Compare
timkpaine
commented
Feb 26, 2025
timkpaine
force-pushed
the
tkp/autogen
branch
3 times, most recently
from
March 4, 2025 22:16
576cf64 to
e3ef98d
Compare
timkpaine
marked this pull request as draft
August 14, 2025 21:27
timkpaine
marked this pull request as ready for review
February 14, 2026 22:51
csp_autogen generates C++ struct bindings at build time, which requires a working Python csp
import during the C++ build. Allow that step to be bypassed by checking generated sources into
the tree: Findcsp_autogen.cmake now prefers in-source csp_autogen/<name>.{h,cpp} when both are
present and only falls back to the generate-at-build-time custom command otherwise.
Adds the pregenerated sources for csp/engine and the websocket adapter, along with
test_pregenerated_types.py to catch them drifting from what the generator would produce.
The generator gains --omit_asserts to drop the static offset/alignment/size assertions, which
are only valid for the interpreter and platform that generated them and so cannot be baked into
checked-in sources. Generated files are stamped with the command that produced them, imports of
csp.impl.enum/struct are deferred to call sites so the module can be imported without a built
csp, and csp/core/Platform.h is added to the common includes.
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
cspmain build