CSP Numba Node - #693
Open
markhalka wants to merge 9 commits into
Open
Conversation
markhalka
force-pushed
the
mh14779/numba-csp-v1
branch
2 times, most recently
from
May 11, 2026 21:48
d071795 to
3274897
Compare
timkpaine
requested changes
May 21, 2026
markhalka
force-pushed
the
mh14779/numba-csp-v1
branch
from
May 29, 2026 18:19
460d5ee to
965219d
Compare
robambalu
reviewed
Jun 10, 2026
| @@ -1,9 +1,9 @@ | |||
| EXTRA_ARGS := | |||
| EXTRA_ARGS := --csp-no-vcpkg | |||
markhalka
marked this pull request as ready for review
July 20, 2026 16:47
markhalka
requested review from
AdamGlustein,
alexddobkin,
arhamchopra,
ptomecek and
svatasoiu
as code owners
July 20, 2026 16:47
markhalka
force-pushed
the
mh14779/numba-csp-v1
branch
2 times, most recently
from
July 20, 2026 17:10
ff8809f to
fa75f57
Compare
robambalu
reviewed
Jul 20, 2026
| # _cspimpl, which would be a circular dep | ||
| spec = importlib.util.find_spec("csp") | ||
| loader = importlib.machinery.SourceFileLoader(spec.name, spec.origin) | ||
| # Use this script's location to find csp package (works for editable installs where spec.origin may be None) |
Collaborator
There was a problem hiding this comment.
what issue is this addressing? I havent had issues building with editable installs
Signed-off-by: Mark Halka <mark.halka2001@gmail.com>
Signed-off-by: Mark Halka <mark.halka2001@gmail.com>
Signed-off-by: Mark Halka <mark.halka2001@gmail.com>
markhalka
force-pushed
the
mh14779/numba-csp-v1
branch
from
July 20, 2026 17:39
fa75f57 to
e3c3a07
Compare
Signed-off-by: Mark Halka <mark.halka2001@gmail.com>
Signed-off-by: Mark Halka <mark.halka2001@gmail.com>
markhalka
force-pushed
the
mh14779/numba-csp-v1
branch
2 times, most recently
from
July 24, 2026 16:53
952bca6 to
a128253
Compare
Signed-off-by: Mark Halka <mark.halka2001@gmail.com>
markhalka
force-pushed
the
mh14779/numba-csp-v1
branch
2 times, most recently
from
July 24, 2026 17:48
b3060e2 to
fbbddbe
Compare
Signed-off-by: Mark Halka <mark.halka2001@gmail.com>
markhalka
force-pushed
the
mh14779/numba-csp-v1
branch
from
July 24, 2026 18:47
fbbddbe to
6414320
Compare
timkpaine
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integrate numba_type_utils into CSP and support CSP specific syntax. Note that numba_type_utils must be made public before this can be merged.