Repository navigation
Fold the 2026-10-17 DoD first prints: review fy2026 strips, move the anchor - #363
Merged
Merged
Conversation
…anchor dd929cb (chronicle#361, the resolve_pending.py append lane) recorded FY2026 first prints for five USAspending DoD series and regenerated the catalog, but the appended wave left two catalog tests red on the base: - test_committed_catalog_is_current_and_valid: fy2026 is the first strip in each series' source_record_id shape usaspending.dod.<series>.{P:fy9999}.registered_query_snapshot. Each observation declares period fiscal_year 2026 and spells it directly (kind derived); the docket entries declare period FY2026 and the USAspending query is keyed by fiscal_year. A period label, so the five strips are recorded as reviewed, with a note. - test_identity_uuid_map_matches_reviewed_anchor: the ten registry events are five retire+succeeds enrichments of geography-free placeholders, each keeping its UUID. Recomputed, 8c4a0f8 reproduces the old pin and the delta to dd929cb is exactly those five tuples re-keyed with the same UUIDs; the other 216 are unchanged. The new digest is pinned with a dated comment. No ledger bytes change; --check stays current at 221 series. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in 86da023 (one first print of an already-observed series, no registry events) so the fold is current with its strict-protected base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MaxGhenis
marked this pull request as ready for review
October 18, 2026 18:06
Contributor
Author
|
Independent review: MERGE (Opus 5.5 on a Subfleet Reviewed head: The reviewer independently confirmed the following:
Disposition of the two NITs:
Since the review, the only change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#361 is the resolve_pending.py append lane. At
dd929cbait recorded FY2026 first prints for five USAspending DoD series and regenerated the catalog. The append lane merges on its own gate, and this wave left two catalog tests red oncodex/thesis-ledger-facts. Arch checks therefore fails for every PR into this base, including #360, the generator fix Thesis needs before the DoD FY2026 window closes on 2026-10-22.What
tests/fixtures/series_catalog/reviewed_stripped_segments.jsontest_committed_catalog_is_current_and_validreportedfy2026as the first strip in each series'source_record_idshape,usaspending.dod.<series>.{P:fy9999}.registered_query_snapshot.fiscal_year 2026and spells it directly; the builder's kind isderived. The docket entries declareperiod: FY2026, and the USAspending query is keyed byfiscal_year.fy2026is therefore a period label, not a statute, cohort or edition label. The five strips are recorded as reviewed, under the concept, field and shape the audit names, with a datedfy2026note.tests/test_build_series_catalog.py,test_identity_uuid_map_matches_reviewed_anchordd929cba's ten registry events are five retire+succeeds enrichments of geography-free placeholders. Each keeps its UUID and takes the observation's US current geography and economy aggregate entity:new_prime_awards(8146ecb0);prime_award_transactions(82ff2d7f);prime_contract_obligations(11ea0d3d);small_business_contract_obligation_share(91e3b668);unique_prime_contract_recipients(96d17026).8c4a0f86reproduces the old pin (56bb47bc…). The delta todd929cbais exactly those five tuples, re-keyed with the same UUIDs; the other 216 are unchanged and there are 221 rows.b06bf665…) is pinned with a dated comment.No ledger bytes change.
Verification
uv run --locked pytest tests/test_build_series_catalog.py -q: 222 passed. On the base tip it fails these 2 tests.uv run --locked python scripts/build_series_catalog.py --check:catalog current: 221 series.uv run --locked ruff check tests/test_build_series_catalog.py: clean.dd929cba's committed catalog. The strip kinds come frombuild_catalog(...)[1]["strips"]on the committed inputs; the digest delta comes from the test's own algorithm applied at8c4a0f86anddd929cba.axiom: n/a: catalog test fixture and anchor, no policy encoding
🤖 Generated with Claude Code