Close out state CTC federal-conformance audit (NC/CO/UT) - #9154
Open
DTrim99 wants to merge 1 commit into
Open
Conversation
Follow-up to the PolicyEngine#6374 audit, resolving the three remaining watch-items: - NC: add a regression test pinning that an ITIN filer's SSN-holding child still receives the NC child deduction in 2025. NC is a static IRC-conformity state (conformed as of Jan 1, 2023), so it does not import the OBBBA filer-SSN gate; nc_child_deduction keys on ctc_qualifying_children (child-SSN gate only). The test fails if a filer-SSN gate is ever propagated into the NC count. No code change. - CO: add a 2023 boundary test proving the rate x co_federal_ctc branch is still active in 2023, guarding the ctc_matched_federal_credit flip date (true 2022 -> false 2024). Confirms the existing 2022 tests correctly exercise the year-active branch; no branch mismatch. No code change. - UT: add the Utah Code 59-10-1047 reference to ut_ctc_potential (was missing). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9154 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 1 -16
Lines 279 24 -255
==========================================
- Hits 279 24 -255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes out the state CTC ↔ federal-conformance audit (#6374) by resolving its three remaining watch-items. Two are verification/regression-only (no behavior change); one adds a missing reference.
NC — regression test (no code change)
The audit's open question was whether NC's "allowed the federal §24 credit" language re-imports the OBBBA (July 2025) filer-SSN gate. It does not: NC is a static IRC-conformity state, conformed to the Code as of Jan 1, 2023 (N.C. Gen. Stat. §105-228.90(b)(1b)), and NCDOR's TY2025 guidance confirms NC does not conform to OBBBA for 2025. §24's child-SSN rule (TCJA, 2018) is in the Jan-1-2023 Code and is correctly imported via
ctc_qualifying_children; the filer-SSN rule (2025) is not. This PR adds a regression test: a 2025 ITIN filer whose qualifying child has a valid SSN still receives the NC child deduction. It fails if a filer-SSN gate is ever propagated into the NC count.CO — boundary test (no code change)
co_ctcselects betweenrate × co_federal_ctc(2022–2023) and a flat per-child amount (2024+) viactc_matched_federal_credit(true → false at 2024-01-01). The existing unit tests jumped from 2022 to 2024, leaving the flip date unguarded. Verified the 2022 tests correctly exercise the rate branch (no mismatch — the watch-item was a false alarm), and added a 2023 case pinning the rate branch is still active in 2023.UT — missing reference
ut_ctc_potential.pyhad noreference. Added Utah Code §59-10-1047 (the statute the surrounding parameters already cite).Testing
nc_child_deduction.yaml: 7 passedco_ctc.yaml: 28 passedut_ctc.yaml: 14 passedFixes #6374.
The two remaining audit notes are indefinite watch-items with no action needed today: GA/ID cite §24(c) (the definition subsection, silent on SSNs) with no evidence either state intends ITIN eligibility — revisit only if a DOR confirms coverage.
🤖 Generated with Claude Code