feat(perf): compare frozen queries with Athena - #1154
Open
bill-ph wants to merge 1 commit into
Open
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Athena on-demand as a third protocol in the frozen performance scenario so Duckgres raw Parquet, DuckLake via Duckgres/Trino, and Athena external-table latency are measured over the same immutable files.
Depends on PostHog/posthog-cloud-infra#10231 being applied and its outputs being configured as the repository Athena secret and variables.
Changes
query_results.csvv1 unchanged and addquery_service_metrics.csvfor queue, planning, engine, scanned-byte, DPU, and engine-version dataTesting
just test-unit(passes outside the sandbox)go test ./tests/mw-dev/scenario ./tests/mw-dev/scenario/perf ./tests/mw-dev ./tests/perf/...golangci-lint run ./tests/perf/... ./tests/mw-dev/scenario/...(zero issues)just lintwas run; it reports six pre-existing SA4023 findings inmain.go,cmd/duckgres-controlplane/main.go, andcontrolplane/control.go, outside this changeRollout
Merge and apply the infrastructure PR first, configure
MW_DEV_ATHENA_POD_IDENTITY_ROLE,MW_DEV_ATHENA_WORKGROUP,MW_DEV_ATHENA_DATABASE, andMW_DEV_ATHENA_RESULTS_S3_URI, then merge this PR and manually runposthog_frozen_perf.