Repository navigation
Add scripts/dev.sh and scope the CI jobs to what changed - #25
Merged
Merged
Conversation
`scripts` had nothing to point a fresh checkout at. scripts/dev.sh sets core.hooksPath, which no clone can inherit, then runs the gate CI runs. Doctests get their own step because --all-targets does not run them, and they are what holds the README to the crate. `ci-scoped` flagged test and msrv as running on every pull request with nothing deciding whether they need to. A changes job now answers that once and the four cargo jobs depend on it. On a push there is no base to diff against, so everything counts as changed and main is gated exactly as before. The filter names what cannot affect a build -- DESIGN.md, CHANGELOG.md, images/ -- rather than what can, so an unfamiliar file is treated as code until someone decides otherwise. README.md is deliberately not on that list: its Rust snippets are doctests and `cargo package` ships it, so a README-only change really does have to run the suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0144PU3MssnfbM5tZiqXW7d3
zmaril
force-pushed
the
dev-script-and-ci-scoping
branch
from
August 29, 2026 23:53
aee2e92 to
49c1a12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fleet findings:
scriptsandci-scoped.scriptsscripts/dev.shsetscore.hooksPath, which no clone can inherit, then runs the gate CI runs: build, fmt, clippy, the tests, and the doctests. The doctests are a separate step because--all-targetsdoes not run them, and they are what holds the README to the crate. It is named in a new Development section in the README, and is ShellCheck-clean at--severity=warning.ci-scopedtestandmsrvwere flagged as running on every pull request with nothing deciding whether they need to. Achangesjob now answers that once, and all four cargo jobs (test,examples,msrv,packaging) depend on it. It follows the fleet lint workflow's pattern:fetch-depth: 0, a diff of${{ github.event.pull_request.base.sha }}...HEAD, and an empty base treated as "everything changed", so a push to main still runs the whole file.timeout-minutes: 5.The filter names what cannot affect a build —
DESIGN.md,CHANGELOG.md,images/— rather than what can, so an unfamiliar new file is treated as code until somebody decides otherwise.README.mdis deliberately absent from that list: every Rust snippet in it is a doctest andcargo packageships it, so a README-only change really does have to run the suite.Verification
ordnung checkon this branch:Failing checks went from 23 to 21 against
origin/main, with nothing newly failing. The workflow parses underyaml.safe_load.🤖 Generated with Claude Code
https://claude.ai/code/session_0144PU3MssnfbM5tZiqXW7d3