Localize dsc-lib tracing and standardize builds - #1720
Open
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Open
Localize dsc-lib tracing and standardize builds#1720Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
Conversation
Move hard-coded tracing text into the en-us locale and render it through rust-i18n. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add repository-wide Copilot guidance and align the build documentation to avoid direct Cargo build commands. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Steve Lee (SteveL-MSFT)
September 11, 2026 22:38
View session
Steve Lee (SteveL-MSFT)
requested review from
Mikey Lombardi (He/Him) (michaeltlombardi) and
Tess Gauthier (tgauth)
September 11, 2026 22:39
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
This pull request localizes dsc-lib tracing messages and standardizes repository builds around build.ps1.
Changes:
- Replaced hard-coded tracing messages with
rust_i18n::t!(). - Added corresponding English locale entries.
- Added repository and Copilot build guidance.
File summaries
| File | Description |
|---|---|
lib/dsc-lib/src/functions/mod_function.rs |
Localizes mod tracing. |
lib/dsc-lib/src/functions/max.rs |
Localizes max tracing. |
lib/dsc-lib/src/extensions/discover.rs |
Localizes manifest import logging. |
lib/dsc-lib/src/dscresources/dscresource.rs |
Localizes resource tracing. |
lib/dsc-lib/src/dscresources/command_resource.rs |
Localizes command and process tracing. |
lib/dsc-lib/src/discovery/command_discovery.rs |
Localizes discovery diagnostics. |
lib/dsc-lib/src/configure/mod.rs |
Localizes configuration diagnostics. |
lib/dsc-lib/src/configure/depends_on.rs |
Localizes dependency-order tracing. |
lib/dsc-lib/locales/en-us.toml |
Adds translation keys. |
.github/instructions/instructions.md |
Documents standardized builds. |
.github/copilot-instructions.md |
Adds build guidance. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
😊 Code Coverage ReportChanged Code Coverage82% (80%+ coverage)
🔵 Full Codebase Coverage82% (good)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard-coded English tracing messages in
dsc-libbypass localization and make diagnostics inconsistent with the rest of the engine. This change moves those messages intoen-us.tomland renders them through therust_i18n::t!()macro.It also adds repository-wide Copilot guidance requiring builds to run through
build.ps1, ensuring grammar generation and other setup steps happen before Rust compilation instead of invoking Cargo directly.Validation
./build.ps1 -Project dsc-lib