Skip to content

Localize dsc-lib tracing and standardize builds - #1720

Open
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
mainfrom
stevel-msft-localize-trace-strings
Open

Localize dsc-lib tracing and standardize builds#1720
Steve Lee (SteveL-MSFT) wants to merge 2 commits into
mainfrom
stevel-msft-localize-trace-strings

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

Hard-coded English tracing messages in dsc-lib bypass localization and make diagnostics inconsistent with the rest of the engine. This change moves those messages into en-us.toml and renders them through the rust_i18n::t!() macro.

It also adds repository-wide Copilot guidance requiring builds to run through build.ps1, ensuring grammar generation and other setup steps happen before Rust compilation instead of invoking Cargo directly.

Validation

  • ./build.ps1 -Project dsc-lib

Steve Lee (POWERSHELL HE/HIM) (from Dev Box) and others added 2 commits September 11, 2026 15:37
Move hard-coded tracing text into the en-us locale and render it through rust-i18n.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add repository-wide Copilot guidance and align the build documentation to avoid direct Cargo build commands.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues remain.

Pull request overview

This pull request localizes dsc-lib tracing messages and standardizes repository builds around build.ps1.

Changes:

  • Replaced hard-coded tracing messages with rust_i18n::t!().
  • Added corresponding English locale entries.
  • Added repository and Copilot build guidance.
File summaries
File Description
lib/dsc-lib/src/functions/mod_function.rs Localizes mod tracing.
lib/dsc-lib/src/functions/max.rs Localizes max tracing.
lib/dsc-lib/src/extensions/discover.rs Localizes manifest import logging.
lib/dsc-lib/src/dscresources/dscresource.rs Localizes resource tracing.
lib/dsc-lib/src/dscresources/command_resource.rs Localizes command and process tracing.
lib/dsc-lib/src/discovery/command_discovery.rs Localizes discovery diagnostics.
lib/dsc-lib/src/configure/mod.rs Localizes configuration diagnostics.
lib/dsc-lib/src/configure/depends_on.rs Localizes dependency-order tracing.
lib/dsc-lib/locales/en-us.toml Adds translation keys.
.github/instructions/instructions.md Documents standardized builds.
.github/copilot-instructions.md Adds build guidance.
Review details
  • Files reviewed: 11/11 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown

😊 Code Coverage Report

Changed Code Coverage

82% (80%+ coverage)

Metric Value
Changed lines analyzed 41
Lines covered by tests 34
Coverage percentage 82%

🔵 Full Codebase Coverage

82% (good)

Metric Value
Total executable lines 19400
Lines covered by tests 16085
Coverage percentage 82%

Changed code coverage measures only Rust lines added/modified in this PR.
Full codebase coverage measures all instrumented Rust lines across the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants