Change repo used in ContainerRegistry Find-PSResource with wildcard name test - #2042
Merged
Merged
Conversation
Anam Navied (anamnavi)
requested review from
Sydney Smith (SydneyhSmith),
Aditya Patwardhan (adityapatwardhan),
alerickson and
shammu1
as code owners
September 15, 2026 20:10
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🔵 Needs a closer look
CI setup must provision and seed the new registry before approval.
Pull request overview
This PR updates the Container Registry wildcard Find-PSResource test to use a dedicated ACR repository.
Changes:
- Adds the wildcard-test registry configuration.
- Redirects the wildcard lookup test to it.
File summaries
| File | Summary |
|---|---|
test/FindPSResourceTests/FindPSResourceContainerRegistryServer.Tests.ps1 |
Adds and uses the dedicated wildcard ACR repository. |
The new registry is not provisioned or seeded by CI, so the test may fail without exercising wildcard lookup.
Review details
Suppressed comments (1)
test/FindPSResourceTests/FindPSResourceContainerRegistryServer.Tests.ps1:20
- This introduces a dependency on
psresourcegettestwildcard.azurecr.io, but the CI setup only verifies and cleanspsresourcegettest(.ci/test.yml:196,.ci/test.yml:272-280) and no fixture/provisioning for the new registry exists in the repository. A clean CI run therefore has no guarantee that this endpoint is reachable or contains any resources, so the test can fail before exercising wildcard lookup. Add the second registry to the CI/infrastructure setup and seed a known package (with appropriate cleanup), or keep this test on a registry controlled by the existing setup.
$ACRRepoWildcardUri = "https://psresourcegettestwildcard.azurecr.io"
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alerickson
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change repo used in ContainerRegistry Find-PSResource with wildcard name test. This is for a CI related improvement.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.