Skip to content

Change repo used in ContainerRegistry Find-PSResource with wildcard name test - #2042

Merged
alerickson merged 1 commit into
masterfrom
acr-test-bugfix
Sep 16, 2026
Merged

alerickson merged 1 commit into
masterfrom
acr-test-bugfix

Conversation

@anamnavi

@anamnavi Anam Navied (anamnavi) commented Sep 15, 2026

Copy link
Copy Markdown
Member

PR Summary

Change repo used in ContainerRegistry Find-PSResource with wildcard name test. This is for a CI related improvement.

PR Context

PR Checklist

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@anamnavi

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

CI setup must provision and seed the new registry before approval.

Pull request overview

This PR updates the Container Registry wildcard Find-PSResource test to use a dedicated ACR repository.

Changes:

  • Adds the wildcard-test registry configuration.
  • Redirects the wildcard lookup test to it.
File summaries
File Summary
test/FindPSResourceTests/FindPSResourceContainerRegistryServer.Tests.ps1 Adds and uses the dedicated wildcard ACR repository.

The new registry is not provisioned or seeded by CI, so the test may fail without exercising wildcard lookup.

Review details

Suppressed comments (1)

test/FindPSResourceTests/FindPSResourceContainerRegistryServer.Tests.ps1:20

  • This introduces a dependency on psresourcegettestwildcard.azurecr.io, but the CI setup only verifies and cleans psresourcegettest (.ci/test.yml:196, .ci/test.yml:272-280) and no fixture/provisioning for the new registry exists in the repository. A clean CI run therefore has no guarantee that this endpoint is reachable or contains any resources, so the test can fail before exercising wildcard lookup. Add the second registry to the CI/infrastructure setup and seed a known package (with appropriate cleanup), or keep this test on a registry controlled by the existing setup.
        $ACRRepoWildcardUri = "https://psresourcegettestwildcard.azurecr.io"
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@alerickson
alerickson merged commit 0dc0bb9 into master Sep 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants