Replace Pester -Pending with -Skip in rule tests - #2208
Andy Jordan (andyleejordan) with Copilot wants to merge 5 commits into
Conversation
Co-authored-by: andyleejordan <2226434+andyleejordan@users.noreply.github.com>
-Pending with -Skip in rule tests
|
kicked off tests, ok with code change. Copilot can you please resolve merge conflicts |
…est-failures # Conflicts: # Tests/Rules/UseIdenticalMandatoryParametersForDSC.tests.ps1 # Tests/Rules/UseToExportFieldsInManifest.tests.ps1 Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Merged Both conflicts were in the same two lines this PR touches — |
|
Copilot diff shows no changes at all in this PR, did you undo your work when you resolved merge conflict? |
No, nothing was undone — the same fix landed on The commit on - It "Should find a violations" -pending {
+ It "Should find a violations" -Skip {
- It "suggests corrections for AliasesToExport with wildcard" -pending:($IsCoreClr) {
+ It "suggests corrections for AliasesToExport with wildcard" -Skip:($IsCoreClr) {That's why the merge conflicted on those exact lines and only those lines: both sides changed Current state on this branch — So the issue is already fixed on |
Andy Jordan (@andyleejordan) it seems your PR has been superseded by #2194 |
Pester v6 removed the
It -Pendingparameter, but two rule tests still used it, causing test run failures unrelated to whatever change is under test.Changes
Tests/Rules/UseIdenticalMandatoryParametersForDSC.tests.ps1:-pending→-skip.Tests/Rules/UseToExportFieldsInManifest.tests.ps1:-pending:($IsCoreClr)→-skip:($IsCoreCLR), also correcting the casing of the automatic variable.Behavior is unchanged — both tests remain unexecuted, now via the supported parameter. A Pester discovery-only run reports
Skip=Truefor both, and no other-Pendingusages remain in the PowerShell test files.-Pending(removed in Pester v6) still used in 2 rule tests unrelated to this PR #2207