[Copilot]

PR Summary

Follow-up to #2270, targeting its branch rather than main.

The review finding is reproducible: a resource-shaped call to a script-defined function is treated as a DSC declaration because command discovery uses a separate runspace. Commands inside its script block arguments are then incorrectly suppressed. Both new regression cases returned zero diagnostics before the fix instead of the two expected diagnostics.

• Recognize function declarations in enclosing script-block scopes, case-insensitively, without searching unrelated nested scopes.
• Use that information consistently for resource declarations and their same-line/following-line bodies. Do not apply implicit Get- prefix corrections to script-defined function calls; preserve explicit alias handling.
• Cover script-level and configuration-level functions, both brace layouts, unrelated scopes, and formatter behavior. Document the distinction.

Validation: .NET 8 and .NET Framework 4.6.2 builds succeeded. Alias tests: 23 passed, 2 Windows-only tests skipped on Linux. Formatter integration tests: 10 passed. Executed using PowerShell 7.4.13 and Pester 5.7.1; the configured Pester 6.0.1 package was unavailable from the accessible mirror.

PR Checklist

• PR has a meaningful title
• Summarized changes
• Change is not breaking
• All changed source files have the correct copyright header
• Added regression tests and updated documentation
• This PR is ready to merge and is not Work in Progress (opened as a draft)

[Copilot]

🟡 Changes recommended

Scoped function declarations are mishandled, causing incorrect alias rewrites and suppressed diagnostics, while repeated scope scans introduce quadratic analysis overhead.

2 open issues

• Handle scoped function declarations and visibility in analysis · New
• Index function declarations to avoid repeated AST traversal · New

What changed in this PR

This follow-up to #2270 distinguishes script-defined function calls from DSC resource declarations so alias analysis preserves function names while checking commands in their script-block arguments.

Changes:

• Adds case-insensitive function lookup in enclosing script-block scopes and reuses it in DSC classification.
• Adds regression coverage for function scope, brace layouts, unrelated scopes, and formatter behavior.
• Documents the distinction between functions, DSC resources, and implicit aliases.

File	Description
Tests/​Rules/​AvoidUsingAlias.tests.ps1	Adds function-detection and formatter regression tests.
Rules/​AvoidAlias.cs	Uses script-defined function detection in alias and DSC handling.
docs/​Rules/​AvoidUsingCmdletAliases.md	Explains function and DSC resource exclusions from implicit alias correction.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Scope handling still changes command resolution for dot-sourced private functions and incorrectly treats script/global declarations in unexecuted nested functions as visible, causing missed diagnostics and unsafe corrections.

2 open issues

• Handle dot-sourced blocks using caller scope · New
• Keep nested script/global declarations in lexical scope · New

2 resolved since last review

• Index function declarations to avoid repeated AST traversal
• Handle scoped function declarations and visibility in analysis

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Dot-sourced scope handling still misindexes declarations and incorrectly skips script-block argument scopes, causing both erroneous alias corrections and missed diagnostics.

2 open issues

• Avoid skipping scopes for script-block command arguments · New
• Index dot-sourced declarations in the effective caller scope · New

2 resolved since last review

• Keep nested script/global declarations in lexical scope
• Handle dot-sourced blocks using caller scope

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The argument-count restriction incorrectly treats parameterized dot-sourced blocks as child scopes, causing erroneous alias formatting and missed declarations in the caller’s scope.

1 open issue

• Fix scope handling for parameterized dot-sourced blocks · New

2 resolved since last review

• Index dot-sourced declarations in the effective caller scope
• Avoid skipping scopes for script-block command arguments

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved command-shadowing and callback-scope errors can cause incorrect alias replacements and suppress expected diagnostics.

4 open issues

• Stop scope lookup at all isolated execution boundaries · New
• Honor visible script-defined commands before callback scope rules · New
• Resolve callback blocks inside array arguments · New
• Resolve trailing callbacks from RemainingScripts · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Mutually recursive scope checks can stall analysis on nested callbacks, while unresolved function-visibility and scope-boundary errors cause missed diagnostics and behavior-changing corrections.

7 open issues

• Prevent exponential recursion in scope visibility checks · New
• Preserve alias precedence in callback scope detection · New
• Respect declaration order when resolving same-scope functions · New
• Resolve dot-sourced declarations before classifying callbacks · New
• Treat NoNewScope callbacks as caller-scoped · New
• Recognize standalone DSC property script blocks · New
• Account for parameter binding when identifying callback blocks · New

4 resolved since last review

• Resolve trailing callbacks from RemainingScripts
• Resolve callback blocks inside array arguments
• Honor visible script-defined commands before callback scope rules
• Stop scope lookup at all isolated execution boundaries

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved scope, execution-order, and callback-classification errors in AvoidAlias suppress expected diagnostics and can incorrectly rewrite valid function calls.

5 open issues

• Account for execution order across caller-scoped blocks · New
• Recognize remote Invoke-Command parameter sets · New
• Recognize callbacks inside array subexpressions · New
• Exclude ForEach-Object member-invocation arguments from callbacks · New
• Honor statically false NoNewScope values · New

7 resolved since last review

• Prevent exponential recursion in scope visibility checks
• Account for parameter binding when identifying callback blocks
• Recognize standalone DSC property script blocks
• Treat NoNewScope callbacks as caller-scoped
• Resolve dot-sourced declarations before classifying callbacks
• Respect declaration order when resolving same-scope functions
• Preserve alias precedence in callback scope detection

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Unresolved positional-argument handling, callback classification, and execution-order bugs in AvoidAlias suppress expected Get-Verb diagnostics and cause the formatter to replace valid function calls.

2 open issues

• Compare callback declarations by execution phase, not source order · New
• Skip positional arguments for switches and parameters with attached values · New

5 resolved since last review

• Honor statically false NoNewScope values
• Exclude ForEach-Object member-invocation arguments from callbacks
• Recognize callbacks inside array subexpressions
• Recognize remote Invoke-Command parameter sets
• Account for execution order across caller-scoped blocks

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Human assessment is needed because interacting scope, execution-order, DSC-property, and runspace-boundary cases can incorrectly suppress diagnostics or cause erroneous formatter changes.

No open issues 🎉

2 resolved since last review

• Skip positional arguments for switches and parameters with attached values
• Compare callback declarations by execution phase, not source order

_{Review effort: Balanced}