Skip to content

fix(deps): Next.js 16.4.6 and a reviewed exception for picomatch - #3642

Merged
Priyanshu-byte-coder merged 1 commit into
mainfrom
fix/security-audit-2026-11-18
Nov 18, 2026
Merged

Priyanshu-byte-coder merged 1 commit into
mainfrom
fix/security-audit-2026-11-18

Conversation

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Summary

The Dependency audit CI job started failing on every branch (it blocked #3641) because of three new advisories. This fixes all three.

Advisory Package Fix
GHSA-mfr8-8qww-v76h (moderate) next ≤ 16.4.4 upgrade
GHSA-vc7v-qv4w-wrv8 (moderate) next ≤ 16.4.4 upgrade
GHSA-fc5q-39xc-vjpf (high) picomatch ≤ 4.0.7 no fixed release exists; accepted with a review date

What changed

  • next, @next/env and eslint-config-next → 16.4.6 (patch releases in the same minor; 16.4.5 is the first fixed version).
  • patches/accepted-advisories.json (new): advisories with no fixed release that the app can't reach, each with a reason and a reviewBy date. scripts/security-audit.cjs lets these through until that date, then fails again with a message to check for a fix.
  • picomatch is the only entry, until 2027-01-31. Its ReDoS needs an attacker to supply the glob pattern. Here picomatch only arrives through build tooling (next-pwa/workbox, @sentry/nextjs's rollup plugin, next-intl's file watcher), which matches globs written in this repository; no request input becomes a glob.
  • docs/repairs/dependency-audit.json: the audit report the script regenerates.

Checks

  • node scripts/security-audit.cjs: passes locally (1 accepted, no unmitigated advisories).
  • CI runs the full build, type check and tests on Next 16.4.6.

After this merges, #3641 needs Update branch to pick it up.

The dependency audit started failing on every branch after new advisories:

- next GHSA-mfr8-8qww-v76h and GHSA-vc7v-qv4w-wrv8 (moderate, 'use cache'
  leaks across root params): fixed in 16.4.5. next, @next/env and
  eslint-config-next move to 16.4.6, the current patch release.
- picomatch GHSA-fc5q-39xc-vjpf (high, ReDoS from attacker-supplied globs):
  no fixed release exists. picomatch only reaches production dependencies
  through build tooling that matches globs written in this repo, so it is
  listed in patches/accepted-advisories.json with the reason and a review
  date of 2027-01-31. After that date the audit fails again until someone
  looks.
@github-actions github-actions Bot added the type:bug GSSoC type bonus: bug fix label Nov 18, 2026
@Priyanshu-byte-coder
Priyanshu-byte-coder merged commit 9647317 into main Nov 18, 2026
13 checks passed
@Priyanshu-byte-coder
Priyanshu-byte-coder deleted the fix/security-audit-2026-11-18 branch November 18, 2026 20:28
@github-actions

Copy link
Copy Markdown

🎉 Merged! Thanks for contributing to DevTrack.

If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers.

Keep an eye on open issues for your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug GSSoC type bonus: bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant