Repository navigation
fix: read a store marker with a BOM the same way on every macOS (#770) - #774
Merged
Merged
Conversation
CI reached its tests for the first time and two failed, both passing locally. The reader relied on Foundation dropping a BOM, which the macOS 15 runner does not do, so a store opened on one machine was malformed on another. The reader now removes it. The offline regeneration test needs SwiftPM's global cache, which CI did not keep; ci.yml now caches it, under a key of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #770
After #773,
ci.ymlreached its tests for the first time: 5547 tests ran, and two failed. Both pass locally.StoreVersion.readrelied on Foundation dropping the BOM. Themacos-15runner keeps it, so the marker was malformed there and accepted locally: the same store would not open on one machine and would on another.StoreMarkerMatrixTestswent red because that is its job. The reader now removes the BOM itself, which matches what the matrix already specifies..build, so on a cache hit nothing was ever fetched and that cache was empty.ci.ymlnow caches it too, under a key of its own, becausecensus-parity.ymlcaches a different path.Verification
StoreMarkerMatrixTestsandStoreVersionTestspass locally, and.githooks/pre-pushpassed on this commit.ci.ymlafter the merge. The new cache key means that run rebuilds from nothing, and the steps afterTesthave not run for a while, so they may show something else.No close trailer: #770 closes when
ci.ymlis seen green or the remaining failures are filed.