Skip to content

fix: read a store marker with a BOM the same way on every macOS (#770) - #774

Merged
kiki830621 merged 1 commit into
mainfrom
idd/770-ci-tests-on-runner
Nov 9, 2026
Merged

kiki830621 merged 1 commit into
mainfrom
idd/770-ci-tests-on-runner

Conversation

@kiki830621

Copy link
Copy Markdown
Member

Refs #770

After #773, ci.yml reached its tests for the first time: 5547 tests ran, and two failed. Both pass locally.

  • A store marker with a BOM. StoreVersion.read relied on Foundation dropping the BOM. The macos-15 runner keeps it, so the marker was malformed there and accepted locally: the same store would not open on one machine and would on another. StoreMarkerMatrixTests went red because that is its job. The reader now removes the BOM itself, which matches what the matrix already specifies.
  • Offline regeneration of the Unicode tables. The test rebuilds the generator with the network blocked, on a new scratch path, so its dependencies must come from SwiftPM's global cache. CI cached only .build, so on a cache hit nothing was ever fetched and that cache was empty. ci.yml now caches it too, under a key of its own, because census-parity.yml caches a different path.

Verification

  • StoreMarkerMatrixTests and StoreVersionTests pass locally, and .githooks/pre-push passed on this commit.
  • Neither fix can be shown locally, because neither failure happens here. They show on ci.yml after the merge. The new cache key means that run rebuilds from nothing, and the steps after Test have not run for a while, so they may show something else.

No close trailer: #770 closes when ci.yml is seen green or the remaining failures are filed.

CI reached its tests for the first time and two failed, both passing locally.
The reader relied on Foundation dropping a BOM, which the macOS 15 runner does
not do, so a store opened on one machine was malformed on another. The reader
now removes it. The offline regeneration test needs SwiftPM's global cache,
which CI did not keep; ci.yml now caches it, under a key of its own.
@kiki830621
kiki830621 merged commit dad21f8 into main Nov 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant