Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e57163e
docs: propose a spec change on every issue, with a check per requirem…
kiki830621 Nov 10, 2026
5200207
chore: merge main (3.7.0: #392, #424) into the #480 branch (#480)
kiki830621 Nov 10, 2026
a833909
docs: task 1.1 — the proposal re-checked against 3.7.0 (#480)
kiki830621 Nov 10, 2026
e2a6ce6
feat: scripts/spec-change.py — declared, archived, links and prefligh…
kiki830621 Nov 10, 2026
fa29468
feat: the spec wrapper — shared contract, idd-implement, idd-plan, id…
kiki830621 Nov 10, 2026
e32aa34
feat: verify reads the specs, fixes go through the wrapper, close wai…
kiki830621 Nov 10, 2026
ac2f211
docs: routing rule, guides, changelog and README follow the spec wrap…
kiki830621 Nov 10, 2026
644b1c1
feat: the spec wrapper unparks the change itself and tells Spectra wh…
kiki830621 Nov 10, 2026
7a3fbc1
feat: the link check ignores the separator Spectra puts between requi…
kiki830621 Nov 10, 2026
6fc8776
docs: idd-implement points its propose and apply calls at contract st…
kiki830621 Nov 10, 2026
afc2c67
docs: record the end-to-end results for tasks 3.2, 3.3, 3.5, 4.1 and …
kiki830621 Nov 10, 2026
7da8cfc
docs: record the end-to-end result for task 4.2 (#480)
kiki830621 Nov 10, 2026
10448f5
docs: record the end-to-end result for task 3.4 and tick 5.2 (#480)
kiki830621 Nov 10, 2026
2f0f97f
fix: what spectra-verify found before the archive, and the archive/ e…
kiki830621 Nov 10, 2026
3eaa895
chore: archive spec-on-every-issue (#480)
kiki830621 Nov 10, 2026
f33ae37
fix: verify round 1 of #480 — one comment selection, links fails clos…
kiki830621 Nov 10, 2026
27ab45e
fix: what spectra-verify found on idd-480-fix1 before its archive (#480)
kiki830621 Nov 10, 2026
90f1b5a
chore: archive idd-480-fix1 (#480)
kiki830621 Nov 10, 2026
83e93a6
fix: verify round 2 of #480 — fences and duplicate names in links, st…
kiki830621 Nov 10, 2026
0d40363
fix: what spectra-verify found on idd-480-fix2 before its archive (#480)
kiki830621 Nov 10, 2026
6758bf3
chore: archive idd-480-fix2 (#480)
kiki830621 Nov 10, 2026
0149a10
fix: verify round 3 of #480 — one fence rule for declared and links, …
kiki830621 Nov 10, 2026
fd2a1d0
fix: what spectra-verify found on idd-480-fix3 before its archive (#480)
kiki830621 Nov 10, 2026
93f8991
chore: archive idd-480-fix3 (#480)
kiki830621 Nov 10, 2026
fee863c
fix: verify round 4 of #480 — keep the Plan routing question, the Spe…
kiki830621 Nov 10, 2026
ab19635
fix: a rejected plan is never applied, and the Plan question comes be…
kiki830621 Nov 10, 2026
f089db8
chore: archive idd-480-fix4 (#480)
kiki830621 Nov 10, 2026
bbd440b
fix: verify round 5 of #480 — a plan is proposed before it is approve…
kiki830621 Nov 11, 2026
c0008cd
fix: idd-plan is the approval path for any open change that is not ap…
kiki830621 Nov 11, 2026
b6bb63b
chore: archive idd-480-fix5 (#480)
kiki830621 Nov 11, 2026
154d337
fix: a Plan-tier approval covers the change's own files (#480)
kiki830621 Nov 11, 2026
44bf701
fix: what spectra-verify found on idd-480-fix6 before its archive (#480)
kiki830621 Nov 11, 2026
220aa7f
chore: archive idd-480-fix6 (#480)
kiki830621 Nov 11, 2026
f5b6199
refactor: the attended Plan tier approves the Implementation Plan, id…
kiki830621 Nov 11, 2026
e3c7f17
fix: what spectra-verify found on idd-480-fix7 before its archive (#480)
kiki830621 Nov 11, 2026
87bd9d0
chore: archive idd-480-fix7 (#480)
kiki830621 Nov 11, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@
| Step 1.6 — auto-close was honoured by GitHub on merge | "Should I still post the closing summary?" (default yes) |
| Unchecked `- [ ]` items remain | (no question — refuses with the list of unchecked items) |

**Workflow position**: last step in the standard IDD pipeline. Spectra changes additionally chain through `/spectra-archive`.
**Workflow position**: last step in the standard IDD pipeline. A declared Spectra change is archived on the branch before verify (#480); `idd-close` Step 1.57 checks that the archive is on the default branch.

**Spec**: [`skills/idd-close/SKILL.md`](../plugins/issue-driven-dev/skills/idd-close/SKILL.md)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
schema: spec-driven
created: 2026-11-11
created_by: che cheng <kiki830621@gmail.com>
created_with: claude
archived_by: che cheng <kiki830621@gmail.com>
archived_at: 2026-11-11
50 changes: 50 additions & 0 deletions openspec/changes/archive/2026-11-11-idd-480-fix1/proposal.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
## Problem

Verify round 1 of #480 (2026-11-11, on `3eaa895`) found that several gates of `spec-on-every-issue` report success without the property holding, and that some paths the spec promises cannot be reached:

- `idd-close` Step 1.57 names a variable (`IC_BODY`) that no step sets; a failed comment fetch gives an empty file, which reads as a legacy comment and passes the close gate.
- In `idd-all` Phase 3b the old "spectra on PATH" check runs before the preflight, so a third-party clone without Spectra aborts instead of proceeding.
- When verify rejects a `no behaviour change` declaration, the fix rules only cover issues that already declared a change; nothing says the fix must create the issue's first change.
- `spec-change.py links` prints `ok` when a requirement heading cannot be parsed (`### Requirement Missing colon`) and when the spec directory is absent at the head revision; a marker for the Example `alpha` is satisfied by a line naming `alpha table`.
- `preflight` prints `error` (exit 2) for a directory that is not a git repository, which no requirement states.
- When the wrapper cannot read the account's permission, it passes `--can-write no` and treats the maintainer's own repository as a third-party clone.
- The Spectra tier's propose arguments do not ask for Examples and markers, and no reviewer is asked whether a `No executable check:` reason holds.

## Root Cause

The gates were specified by what they print for each input, but the inputs they are handed were assembled in prose (the comment selection in `idd-close`) or defaulted silently (permission, empty file), and the parser of requirement blocks treated anything it did not recognise as absent.

## Proposed Solution

- One way to choose the Implementation Complete comment: a `spec-change.py ic` subcommand reads the comments JSON that `gh api --paginate` returns and prints the newest one by an OWNER, MEMBER or COLLABORATOR. `idd-verify` and `idd-close` both use it, and a failed fetch stops the close gate and is reported as `unreadable` by verify.
- `links` reports `error` for a heading that names a requirement but does not parse, and when the spec directory has no tracked file at the head revision; a marker counts only when nothing but whitespace or a comment closer follows it on its line.
- `preflight`'s `error` status is written into the requirement and its Example.
- The wrapper stops when the permission cannot be read; Phase 3b runs the preflight before the CLI check and passes the Example and marker instructions to propose; a rejected exemption is fixed by creating the issue's first change.
- `idd-verify` reviewers judge `No executable check:` reasons.

## Non-Goals

- A legacy comment (no marker, no `**Spec**:` line) stays exempt: telling an old comment from one the wrapper forgot needs a cut-over rule of its own. Follow-up issue.
- Tying a declared change to the issue (an old archived change name passes `archived`): change names are not always `idd-<N>-…`. Follow-up issue.
- The LOW findings of round 1. Follow-up issue.

## Success Criteria

- Each new Example row has a test carrying its marker, and each failed on the commit before the fix.
- `spec-change.py links` over this change's range prints `ok`; `archived --ref HEAD` prints `pass` for a comment that declares both changes.
- Verify round 2 reports no HIGH and no MEDIUM in scope.

## Impact

- Affected specs: spec-on-every-issue, idd-verify
- Affected code:
- Modified: plugins/issue-driven-dev/scripts/spec-change.py
- Modified: plugins/issue-driven-dev/scripts/tests/spec-change/test.sh
- Modified: plugins/issue-driven-dev/scripts/tests/spec-close-gate/test.sh
- Modified: plugins/issue-driven-dev/scripts/tests/spec-wrapper-contract/test.sh
- Modified: plugins/issue-driven-dev/references/spec-wrapper.md
- Modified: plugins/issue-driven-dev/skills/idd-close/SKILL.md
- Modified: plugins/issue-driven-dev/skills/idd-verify/SKILL.md
- Modified: plugins/issue-driven-dev/skills/idd-all/SKILL.md
- Modified: plugins/issue-driven-dev/skills/idd-implement/SKILL.md
- Modified: plugins/issue-driven-dev/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
## MODIFIED Requirements

### Requirement: Reviewers check behaviour against the specs

When `idd-verify` reviews an implementation of an issue under the `code` profile, it SHALL give every reviewer the `**Spec**:` line of the issue's newest Implementation Complete comment and the list of files under `openspec/specs/` that the reviewed range changes. It SHALL choose the comment with `spec-change.py ic` and SHALL run `scripts/spec-change.py links` with `--base` set to the base of the reviewed range, and `scripts/spec-change.py archived` with `--ref` set to the head of the reviewed range, and SHALL list as a Blocking finding each item `links` reports as missing, each change `archived` refuses, either command ending in `error` or printing no JSON, and a declaration that cannot be read because the comments could not be fetched, or whose form is `invalid`. The regression lens SHALL report as a HIGH finding a behaviour change in the range that no requirement in the specs at the head of the range states, and SHALL report as a HIGH finding any behaviour change in the range when the `**Spec**:` line is `no behaviour change`. A test that carries an Example's marker and does not exercise what the Example states SHALL be reported as a finding of MEDIUM or above, and so SHALL a `No executable check:` line under a requirement in the range whose reason does not hold because a check could be written. An issue whose comment is legacy or declares `third-party clone`, and the `prose` and `academic` profiles, are not changed by this requirement; for those comments the results of `links` and `archived` are shown but give no finding (a third-party clone usually has no spec directory, where `links` prints `error`).

What the report holds:

| `**Spec**:` line | Behaviour change in the range | A requirement at the head states it | `links` | `archived` | Finding from this requirement |
| --- | --- | --- | --- | --- | --- |
| `change idd-7-x` | yes | yes | `ok` | `pass` | none |
| `change idd-7-x` | yes | no | `ok` | `pass` | HIGH: behaviour without a requirement |
| `change idd-7-x` | yes | yes | `missing`: one Example | `pass` | Blocking: the Example has no test |
| `change idd-7-x` | yes | yes | `ok` | `refuse` | Blocking: the change is not archived at the reviewed head |
| `change idd-7-x` | yes | yes | `error` | `pass` | Blocking: the link check did not run |
| `no behaviour change` | no | not applicable | `ok` | `pass` | none |
| `no behaviour change` | yes | not applicable | `ok` | `pass` | HIGH: the exemption does not hold |
| `third-party clone` | yes | not applicable | `ok`, or `error` with no spec directory | `pass` | none |
| the comments could not be fetched | yes | not read | `ok` | not run | Blocking: the declaration could not be read |
| `change idd-7-x` | yes | yes, with `No executable check:` although a test could check it | `ok` | `pass` | MEDIUM: the reason does not hold |
| a reviewed range of the last three commits on the default branch | yes | yes | run with `--base HEAD~3` | `pass` | none |

No executable check: the reviewers and the report are produced by a model; the two commands the skill runs have their own Examples in the capability `spec-on-every-issue`.

#### Scenario: Behaviour without a requirement

- **GIVEN** a range that makes a script exit 3 where it exited 0, and no requirement in the specs at the head states its exit codes
- **WHEN** the regression lens reviews the range
- **THEN** the report holds a HIGH finding that names the behaviour change and says no requirement states it

#### Scenario: A declared exemption that is not true

- **GIVEN** an Implementation Complete comment with `**Spec**: no behaviour change`
- **AND** a range that changes which question a skill asks
- **WHEN** the regression lens reviews the range
- **THEN** the report holds a HIGH finding that the declared exemption does not hold
Loading
Loading