Skip to content

test: make the edit-run limit checks say why they fail, and bound the limit by measured CI time (#519) - #530

Merged
kiki830621 merged 2 commits into
mainfrom
idd/519-enhancement-edit-run-time-limit-low-and-
Nov 13, 2026
Merged

kiki830621 merged 2 commits into
mainfrom
idd/519-enhancement-edit-run-time-limit-low-and-

Conversation

@kiki830621

Copy link
Copy Markdown
Member

Refs #519

Summary

#508 的 verify 留下的四個小項,都在 edit-run 檢查自己時限的那一段,以及講同一件事的說明文字。

  • plugins/issue-driven-dev/scripts/tests/edit-run/test.sh:時限的上限從 600 秒改成 480 秒(那三天 28 次 CI 裡最慢的 job 是 654 秒,job 的時限是 1200 秒,卡住時 runner 仍來得及回報);檢查失敗時,失敗訊息帶巢狀 runner 的結束碼與輸出尾段;加一個沒有 timeout 檔的對照,必須逾時;整段移到清理設定之後,沙盒放在工作目錄底下,被中斷時一起清掉。
  • run-all-tests.sh 只改檔頭的註解;CHANGELOG 改的是還沒發版的 [Unreleased] 條目。三處說明文字改成量到的數字並註明出處。
  • edit-run/timeout 的值不變(480),runner 的程式沒有改。規格:宣告 no behaviour change(只改測試)。

verify 跑了兩輪。第 1 輪找到一個 MEDIUM:新加的一個檢查在 macOS 內建的 bash 3.2 上會假失敗。修正輪拿掉那個檢查與另一個測不到中斷的檢查。第 2 輪沒有 MEDIUM 以上的項目;三列 LOW 與 INFO(註解對 INT 的說法、註解的一處用詞、這一項在 suite 裡沒有檢查)沒有在這條 branch 上處理,與第 1 輪留下的一列(CI 的時間沒有監看)記在 #529。途中另開了 #527:runner 在沒有 timeout 指令的機器上,每個 suite 結束後留下一個 sleep 行程。

Verification

Verify gate clean — see the verify report on issue #519. /idd-all merges this PR next if CI and the close-stage guardrails pass.

Checklist

  • Diagnose ✓
  • Implement (2 commits)
  • Verify — clean
  • No auto-close trailer: /idd-close runs after the merge (idd-all's close stage, or by hand)

Related

#527, #529, #518


🤖 Generated by /idd-all. Do NOT add a GitHub close trailer (Closes/Fixes/Resolves) — IDD discipline requires /idd-close (run by /idd-all's close stage, or by hand) to enforce the checklist gate + closing summary.

… limit by measured CI time (#519)

The upper bound of the suite's own time limit is 480 s, not 600 s: the slowest of the last 24 CI jobs took 654 s, so a hung run still ends before the job's 1200 s limit. A failing limit check now shows the aggregator's exit code and the end of its output, and a control run without the timeout file has to time out. The checks run after the EXIT trap is set and inside the suite's work directory, so an interrupted run leaves nothing behind. The comment in the suite, the header comment of run-all-tests.sh and the unreleased CHANGELOG entry give the measured numbers.
…x, and say where the numbers come from (#519)

The check that read the EXIT trap through a pipe failed under bash 3.2, which prints no traps in the subshell of a pipeline; the other one compared a path with the value assigned on the line before it. Neither could fail because an interrupted run left something behind, so both are removed. The comment now says what an interrupted run does: it removes the sandbox with the suite's work directory, and nothing else. The aggregator's log for the stand-in suite stays (#518), and the nested aggregator is not stopped when the signal reaches the suite's shell alone. The 168 s figure is from the full run recorded on #512. The 654 s figure is the slowest job of the 28 runs of the tests workflow on 2026-11-10 to 11-12 (UTC), not of 24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant