Skip to content

feat: /idd-all verify loop takes a configurable stop mode (#595) - #599

Open
kiki830621 wants to merge 1 commit into
mainfrom
idd/595-verify-stop-modes
Open

kiki830621 wants to merge 1 commit into
mainfrom
idd/595-verify-stop-modes

Conversation

@kiki830621

Copy link
Copy Markdown
Member

Refs #595
Refs #591

Summary

/idd-all 的 verify 迴圈什麼時候停,原本只有一條寫死的規則(無人值守 2 輪、attended 1 輪,只有乾淨才合併)。現在可以設定停止模式:repo config 的 verify_stop.mode,或 /idd-all --stop <mode> 只改這一次。

模式 什麼時候停 停下時合併嗎
early 要修的列(Blocking 加上 LOW 以上的 In-scope fix)是 0,或不再下降 Blocking 是 0 才合併
exhaustive-blocking Blocking 是 0;或最近兩輪 Blocking 都沒有下降 Blocking 是 0 才合併
exhaustive-all Blocking 與 In-scope fix(含 LOW)都是 0;沒有輪數上限 合併
沒有設定 與之前相同 只有乾淨才合併
  • close-stage.py gate 每一輪把計數寫進 run-state;新的 close-stage.py next 依模式與這份紀錄回答「再修一輪」或「停下、合不合併」(scripts/lib/stopmode.py)。輪數不再靠 model 記得。
  • 沒有設定模式時,兩輪上限也由程式把關(idd-all: 無人值守的 verify 輪數上限只寫在 SKILL.md,沒有程式把關,compaction 後會被超過 #591):close stage 擋下紀錄超過 2 輪的無人值守 run,以及 Phase 4 沒判過的報告。
  • 停止模式的合併:合併最後一輪審過的 commit,剩下的列合成一張 follow-up issue;與乾淨的合併過同樣的 guardrail。verify-gate.py 現在對每種判定都讀覆蓋率行與 reviewers 行。
  • 設了模式的 run,24 小時期限從最後一輪 verify 算起;attended run 也自動修(安全漏洞仍交回)。

規格:openspec/specs/idd-pr-hitl-modes(新增 1 條 requirement、修改 2 條);change 封存在 openspec/changes/archive/2026-11-21-verify-stop-modes。

Verification

  • close-stage 套件 625 passed;run-all-tests.sh 75 個套件全過。
  • spectra-verify 與 spectra-review 各由獨立 agent 跑一次,找到的問題(1 Critical、數項 Warning)都已修;修正輪再由第三個 agent 複查,找到的一項也已修。主要修正都做過突變檢查。
  • /idd-verify #595(Codex 單獨審,gpt-6.2-sol、effort high、ultrafast)結果貼在 issue 上。

已知、不在這個 PR

Checklist

  • Diagnose
  • Implement(Spectra change,12 + 6 項任務)
  • Verify — /idd-verify #595 進行中
  • No auto-close trailer: /idd-close runs after the merge

🤖 Generated with Claude Code

A repo config `verify_stop.mode`, or `/idd-all --stop <mode>` for one run,
chooses when the verify-and-fix loop stops and whether that stop merges:

- early: stop when the to-fix count (Blocking plus In-scope fix above LOW)
  is 0 or no longer falls; merge when Blocking is 0
- exhaustive-blocking: fix until Blocking is 0; stop without a merge when
  Blocking did not fall in each of the last two rounds
- exhaustive-all: fix until Blocking and In-scope fix (LOW included) are 0;
  no round limit

Without a mode the loop behaves as before: 2 verify rounds unattended, 1
attended, and only a clean round merges.

close-stage.py gate now records every verify round in the run state, and the
new `close-stage.py next` answers fix or stop from that record
(scripts/lib/stopmode.py), so the model no longer counts rounds. For a run
without a mode this also enforces the two-round limit in code (Refs #591):
the close stage stops an unattended run with more than 2 recorded rounds, or
whose newest report Phase 4 never judged. A stop-mode merge takes the commit
the last round reviewed, files the findings left as one follow-up issue, and
passes the clean merge's guardrails; verify-gate.py now reads the coverage
line and the reviewers line for every verdict so that a FAIL round cannot
merge without them. A stop-mode run's 24-hour age counts from its last round.

Spec: openspec/specs/idd-pr-hitl-modes (1 requirement added, 2 modified);
change archived as openspec/changes/archive/2026-11-21-verify-stop-modes.
Tests: close-stage 625 passed; run-all-tests.sh 75 suites passed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant