Repository navigation
feat: /idd-all verify loop takes a configurable stop mode (#595) - #599
Open
kiki830621 wants to merge 1 commit into
Open
kiki830621 wants to merge 1 commit into
kiki830621 wants to merge 1 commit into
Conversation
A repo config `verify_stop.mode`, or `/idd-all --stop <mode>` for one run, chooses when the verify-and-fix loop stops and whether that stop merges: - early: stop when the to-fix count (Blocking plus In-scope fix above LOW) is 0 or no longer falls; merge when Blocking is 0 - exhaustive-blocking: fix until Blocking is 0; stop without a merge when Blocking did not fall in each of the last two rounds - exhaustive-all: fix until Blocking and In-scope fix (LOW included) are 0; no round limit Without a mode the loop behaves as before: 2 verify rounds unattended, 1 attended, and only a clean round merges. close-stage.py gate now records every verify round in the run state, and the new `close-stage.py next` answers fix or stop from that record (scripts/lib/stopmode.py), so the model no longer counts rounds. For a run without a mode this also enforces the two-round limit in code (Refs #591): the close stage stops an unattended run with more than 2 recorded rounds, or whose newest report Phase 4 never judged. A stop-mode merge takes the commit the last round reviewed, files the findings left as one follow-up issue, and passes the clean merge's guardrails; verify-gate.py now reads the coverage line and the reviewers line for every verdict so that a FAIL round cannot merge without them. A stop-mode run's 24-hour age counts from its last round. Spec: openspec/specs/idd-pr-hitl-modes (1 requirement added, 2 modified); change archived as openspec/changes/archive/2026-11-21-verify-stop-modes. Tests: close-stage 625 passed; run-all-tests.sh 75 suites passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #595
Refs #591
Summary
/idd-all的 verify 迴圈什麼時候停,原本只有一條寫死的規則(無人值守 2 輪、attended 1 輪,只有乾淨才合併)。現在可以設定停止模式:repo config 的verify_stop.mode,或/idd-all --stop <mode>只改這一次。earlyexhaustive-blockingexhaustive-allclose-stage.py gate每一輪把計數寫進 run-state;新的close-stage.py next依模式與這份紀錄回答「再修一輪」或「停下、合不合併」(scripts/lib/stopmode.py)。輪數不再靠 model 記得。verify-gate.py現在對每種判定都讀覆蓋率行與 reviewers 行。規格:
openspec/specs/idd-pr-hitl-modes(新增 1 條 requirement、修改 2 條);change 封存在openspec/changes/archive/2026-11-21-verify-stop-modes。Verification
run-all-tests.sh75 個套件全過。/idd-verify #595(Codex 單獨審,gpt-6.2-sol、effort high、ultrafast)結果貼在 issue 上。已知、不在這個 PR
--stop=…放最後一樣會被忽略。Checklist
/idd-verify #595進行中🤖 Generated with Claude Code