AOT: fix request_parse_body compile/link (#5965)#17316
Open
PurHur wants to merge 1 commit into
Open
Conversation
- Link __compiler_env_register_putenv via EnvLocalRuntime during standalone putenv JIT - Route GetenvJitHelper hashtable fills through phpc_native_ht_set_string_key (nested-JIT safe) - Promote list-unpack assign targets to entry allocas for LLVM dominance (#5965) - Preserve insert blocks across RequestParseBodyRuntime / EnvLocalRuntime nested emits Compile + link green for urlencoded/multipart fixtures; AOT runtime still segfaults at c:main_before_php (follow-up). Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Maintainer triage 2026-07-08: compile/link green per PR body but AOT runtime still segfaults at |
Owner
Author
|
Maintainer triage 2026-07-08: compile/link green per PR body but runtime segfault remains — hold merge until AOT execute passes issue repro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$post = $pair[0]afterrequest_parse_body()by promoting assign targets to entry allocasputenv()throughEnvLocalRuntime(__compiler_env_register_putenv) without nested-JITHashTable::updatebreakageGetenvJitHelperhashtable population throughphpc_native_ht_set_string_key(php-in-PHP, no C runtime growth)RequestParseBodyRuntime/EnvLocalRuntimenested helper emitsVerification
Closes #5965 when runtime segfault is fixed.
Made with Cursor