php-in-php: array_find family closure JIT via ArrayFindJitHelper PHP (#17547)#17550
Merged
Merged
Conversation
…elper PHP (#17547) Delegate closure/arrow callbacks from ArrayFindHelper LLVM loops to ArrayFindRuntime + walkWithClosure nested PHP helper (JitVmHelperLink), matching ArrayMap/ArrayReduce closure paths. Removes dead closure branch from resolvePredicateHandler. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of #14842: route closure/arrow
array_findfamily callbacks through nestedArrayFindJitHelper::walkWithClosurePHP instead of LLVM hashtable walk loops inArrayFindHelper.walkWithClosure()— reusesVmClosureCall+VmArrayValueCallback::predicateMatches(php-src parity)ArrayFindRuntimewith__array_find__closureJitVmHelperLink bridge (php-in-php: JIT ArrayFindHelper — route closure callbacks through ArrayFindJitHelper PHP not LLVM loops (#1492) #17547)ArrayFindHelper::buildFromArraydelegates closures early; removes deadresolvePredicateHandlerclosure branchC runtime shrink
No new C. LLVM closure walk path bypassed for JIT/AOT; user-function proxies still use
ArrayFindHelperLLVM (next slice).Verification
Closes #17547
Made with Cursor