Run unit tests serially in CI - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the unit tests serially in CI, on every platform that runs them.
Why
macOS jobs have been failing intermittently with
signal code 11, and occasionally with real assertion failures rather than just a crash — e.g. on04ecd57:That is cross-test interference, not a runner problem: concurrent CoreData stacks in the same process tread on each other, so a test counting
Personrows sees rows another test inserted.Swift Testing parallelizes in-process by default, independently of SwiftPM's own
--no-paralleldefault (which theswift test --helptext refers to)..serializedsuite traits only serialize within a suite; separate suites still run concurrently, which is why the earlier per-suite traits reduced but did not eliminate the failures.Evidence
Reproduced and verified locally, 12 runs each:
signal code 11--no-parallelChanges
.github/workflows/swift.yml—--no-parallelon the macOS and Linux test steps. Windows, ARM and WebAssembly cross-compile only and run no tests, so they are unaffected.Scripts/coverage.sh— same flag for the coverage run, which is a third place tests execute.Full suite passes serially in debug and release (253 tests), and coverage is 96.37% against the CI threshold of 90.
The existing
.serializedsuite traits are left in place: they still help anyone runningswift testlocally without the flag.