Repository navigation
Fix: separate Split Bregman inner solver options - #820
Merged
mrava87 merged 7 commits intoOct 18, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
mrava87
requested changes
Oct 17, 2026
mrava87
left a comment
Collaborator
There was a problem hiding this comment.
@AHMETHAKANBEZIR1 thanks for the contribution 😄
I provided some comments, mostly on tests needed some cleanup to make sure they are more in line to the other tests in the suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #815.
Outer
tol/rtol/rtol1consume names needed by inner CGLS, preventing callers from configuring its stopping criteria. Add keyword-onlykwargs_solvertosplitbregmanandSplitBregman.solve; its entries override duplicate legacy keywords without modifying the caller's dictionary.Following review, name the compatibility catch-all
**kwargs, document its planned removal in v3.0.0, and use the mergedkwargs_solverconsistently. Simplify the parameter documentation and show only the SciPy LSQR options actually used in the TV example.Keep eight focused new cases using the function API and the suite's backend-aware
np/assertion helpers. The CGLS accuracy and precedence tests use one outer/one inner iteration and an independent dense normal-equation solution. The relative-tolerance test documents its distinct purpose: outerrtol/rtol1configure cost callbacks, while inner CGLS thresholds are passed throughkwargs_solver.Validation on Windows CPU / Python 3.12.14 / NumPy 2.5.4 / SciPy 1.18.1:
spgl1.py:927,np.isreal(A).all()returns a Python bool). They are not claimed resolved; no test skips or unrelated dependency changes were added.examples/with Agg, exit 0. Configured pre-commit checks and diff checks passed.AI disclosure: prepared and tested autonomously with OpenAI Codex. No independent human review is claimed.