Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
L1.proxdualuses a real box projection for complex inputs. For example:Dev returns
[0.+2.j, 1.+0.j]. The first value exceeds the dual magnitude bound, and the second loses its phase. The radial projection is[0.+1.j, 0.6+0.8j].Project complex inputs onto magnitude disks, preserving phase. Refresh the real box bounds from the current weight as well: after a primal call advances a callable weight, the dual proximal currently keeps using its initial bounds. Zero weights and shifted inputs are handled without dividing by zero.
Added regressions for complex/weighted/shifted inputs, Moreau's identity, and callable weights, plus a documented complex example. In 48 native primal-dual runs on recorded audio (CPU/CUDA), all solutions now match an independent scalar shrinkage calculation within
6.7e-16; 16 were previously wrong. All 24 real-input controls remain byte-identical. This verifies the requested optimization problem, without making an audio-quality claim.The full suite passes (286 tests), as do
make lint,make typeannot, and a documentation build with gallery execution disabled, using the project's locked Python 3.11 dependencies. The example was also run directly.AI assistance: OpenAI Codex was used to investigate, implement and validate this fix and draft this PR.