Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sparse-group shrinkage can return NaNs at its pure L1 limit and raises for row grouping on nonsquare arrays:
Dev produces a NaN first column, then raises a broadcasting error. Both calls should return
[[0, 0.5, 2.5], [0, 0, -3.5]].Keep the reduced group dimension for broadcasting, and handle zero norms explicitly in group shrinkage and phase normalization. This also gives finite identity behavior at
sigma=0. Added real/complex endpoint and axis regressions, documentation, and an example.On recorded image patches and audio spectrograms, 21 of 32 direct calls and five of 16 native proximal-gradient runs previously failed or produced nonfinite results. All now match an independent scalar/group calculation within
5.6e-17. The four ordinary mixed-penalty column-grouping controls remain byte-identical. Native solver comparisons use the default column grouping; row grouping is checked through the public proximal method.The full suite passes (290 tests), as do
make lint,make typeannot, and a documentation build with gallery execution disabled, using the project's locked Python 3.11 dependencies. The example was also run directly.AI assistance: OpenAI Codex was used to investigate, implement and validate this fix and draft this PR.