Repository navigation
Conversation
…d scanner xml The BeamShapingCalibration scanner selects Camera and Shaper through a .scan entry generated by scripts/make_calibration_entry.py. Also adapt the extension to the DAQScan 5.3 attributes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
…utside tmp_path Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CAhZwmbyCSpSgfTyicUxuS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SLM calibration (
BeamShapingCalibration, aDAQScanwith the customScan1DCalibrationscanner) was configured by an XML file of the pre-5.3 scanner manager, which no longer exists.resources/holography_calibration.scan: Scan Manager entry selecting the detectorCamera, the actuatorShaperand theBeamShapingCalibrationscanner. The extension executes it withscan_manager.execute_entry(CALIBRATION_ENTRY); the oldholography_calibration.xmlis removed.scripts/make_calibration_entry.pyregenerates the entry with the Scan Manager itself (mock modules named Camera and Shaper), if the entry format changes.BeamShapingCalibration.show_widgetsuses theDAQScan5.3 attributes (dock_command,get_toolbar),save_calibrationno longer fails when the calibration cannot be loaded, straycProfileimport removed, docs mention theCamera/Shapernames.Not tested on a real SLM and camera.
Generated by Claude Code