Repository navigation
Follow the current 5.3.x plugin template - #15
Merged
Merged
Conversation
…kaging, Python >= 3.10 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the plugin followed the template of the first 5.3.x release only (PR #14). Since then the template moved:
AGENTS.mdwas extended, the classifiers are built at packaging time fromrequires-pythonand thesupported_platformsof the plugins, and the build requirespymodaq_utils>=5.3.6. This plugin still declared Python 3.8 and fixed classifiers (3.8 to 3.11).After: the files that the template defines are the template ones.
AGENTS.mdand.gitignoreare copied from the5.3.xbranch ofpymodaq_plugins_template;pyproject.tomlhasrequires-python = ">=3.10", the build requirementpymodaq_utils>=5.3.6, and the classifiers moved to[tool.pymodaq]. The plugin name, description, dependencies and urls are untouched.How: compared every file of the template (
git archiveof5.3.x) with the repository. The workflows,CLAUDE.md,hatch_build.pyand the acceptance test were already the same. Checked locally with PyMoDAQ5.3.x: the editable install builds and the metadata gets the classifiers for Python 3.10 to 3.13,pytestgives 3 passed and 1 skipped (the move plugin test has nothing to run: this package has no actuator), andcheck_pluginreports no error. It still lists two leftover template TODO comments indaq_2Dviewer_OpenCV.py, which the camera rewrite in the next pull request removes. No camera involved here.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg