Repository navigation
Show the CameraBase settings in the OpenCV plugin class and fix the tests for the checkable ROI buttons - #17
Merged
Merged
Conversation
…kable ROI buttons in the tests The settings of the plugin were built by a helper that copied and modified the ones of CameraBase, so the class preamble did not show them. They are now written in the class. The ROI buttons are checkable (utils 5.3.1, pymodaq 5.3.9): the tests press them and the floors follow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
… differences in __init__ Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
seb5g
changed the title
The opencv-python wheel (not the headless one) sets QT_QPA_PLATFORM_PLUGIN_PATH to the Qt plugins it ships when cv2 is imported. The creation of a QApplication with PyQt5 then aborts (seen on CI, Python 3.10 with PyQt5). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Contributor
Author
|
The Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the settings of
DAQ_2DViewer_OpenCVwerecomon_parameters + [...] + webcam_params(), where a helper copied and modifiedcam_paramsofCameraBase, so the class preamble did not show where the camera settings come from. The tests also pressed the ROI buttons with a boolean, which the checkable buttons of utils 5.3.2 no longer accept.After:
params = comon_parameters + [OpenCV settings] + cam_params, likeCameraBaseitself. The webcam differences (colour conversionRGB2GRAYby default, exposure time and buffer hidden) are applied in__init__. The tests press the buttons like the user does.How: removed
webcam_params;tests/test_opencv_camera.pysetscheckedthen activates the parameter; floors raised topymodaq_plugins_utils>=5.3.2,pymodaqandpymodaq_gui5.3.9. Tested locally: 28 passed, 1 skipped. No real webcam.🤖 Generated with Claude Code
https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg