Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Contributor
Author
|
The Generated by Claude Code |
… template Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Nothing told PyMoDAQ that the PiCamera and daqhats viewers only work on a Raspberry Pi: on another system they fail at initialization with an import error.
After:
DAQ_2DViewer_PiCameraandDAQ_1DViewer_daqhatsdeclaresupported_platforms = ('linux',)andsupported_architectures = ('aarch64', 'armv7l'). PyMoDAQ refuses to initialize them elsewhere, with a message. The ZMQ based viewer and actuator run on any system and stay undeclared, so the package classifiers are unchanged (check_plugin --fix-classifiers: up to date).How: one class attribute pair per plugin class (PyMoDAQ >= 5.3.5 reads it, older versions ignore it).
Tested: files compile,
package_platformsreads the declarations. Not tested: initialization on a Raspberry Pi or on another system; the choice of aarch64 and armv7l comes from the picamera2 and daqhats requirements, not from a run on the board.Generated by Claude Code