Skip to content

Declare the platforms supported by the instrument plugins - #16

Open
seb5g wants to merge 2 commits into
mainfrom
feature/supported-platforms
Open

seb5g wants to merge 2 commits into
mainfrom
feature/supported-platforms

Conversation

@seb5g

@seb5g seb5g commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Before:
Nothing told PyMoDAQ that the PiCamera and daqhats viewers only work on a Raspberry Pi: on another system they fail at initialization with an import error.

After:
DAQ_2DViewer_PiCamera and DAQ_1DViewer_daqhats declare supported_platforms = ('linux',) and supported_architectures = ('aarch64', 'armv7l'). PyMoDAQ refuses to initialize them elsewhere, with a message. The ZMQ based viewer and actuator run on any system and stay undeclared, so the package classifiers are unchanged (check_plugin --fix-classifiers: up to date).

How: one class attribute pair per plugin class (PyMoDAQ >= 5.3.5 reads it, older versions ignore it).

Tested: files compile, package_platforms reads the declarations. Not tested: initialization on a Raspberry Pi or on another system; the choice of aarch64 and armv7l comes from the picamera2 and daqhats requirements, not from a run on the board.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg

seb5g commented Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

The tests jobs fail while installing the dependencies: picamera2 needs python-prctl, which cannot be built without the libcap development headers ("You need to install libcap development headers"). The same Tests workflow is already red on main (run of 2026-09-29), and this PR only adds two class attributes, so the failure is not from it. A fix would be to install libcap-dev in the workflow of the plugin (rollout PR #15 is still open); I did not widen this PR for it.


Generated by Claude Code

… template

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants