Repository navigation
docs: explain live_mode_available and hardware_averaging in CameraBase - #13
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tdiso1u1ZhikSutj2Qs5Cg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
CameraBasesetlive_mode_available = Trueandhardware_averaging = Falsewithout saying why, and it was not visible that the camera thread averages the frames itself while the viewer averages them again.After: the class docstring states that the two attributes are independent, and a comment on
hardware_averagingsays it should becomeTrueonce the minimum pymodaq contains the fix of PyMoDAQ #1421 (merged in #1422). No behaviour change.How: comments and docstring only, nothing to test.
Generated by Claude Code