Conversation
Reviewer's GuideImproves ImageViewer toolbar usability by localizing copy/background tooltips and presenting MIME, dimensions, and other metadata in an immediately available native hover tooltip, with width listed before height and translation resources kept complete. Sequence diagram for ImageViewer metadata hover presentationsequenceDiagram
participant User
participant ImagePanel
participant MetaProvider
participant NativeTooltip
User->>ImagePanel: Hover metadata control
ImagePanel->>MetaProvider: GetExif()
MetaProvider-->>ImagePanel: Metadata entries
ImagePanel->>ImagePanel: ShowMeta()
ImagePanel->>NativeTooltip: Display formatted metadata
NativeTooltip-->>User: Show MIME and dimensions immediately
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
zaum
force-pushed
the
upstream-image-viewer-tooltips
branch
from
September 19, 2026 06:41
4192e3d to
9022287
Compare
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="QuickLook.Plugin/QuickLook.Plugin.ImageViewer/ImagePanel.xaml.cs" line_range="431" />
<code_context>
});
- textMeta.Inlines.Remove(textMeta.Inlines.LastInline);
- if (!textMeta.Inlines.Any())
+ textMetaContent.Inlines.Remove(textMetaContent.Inlines.LastInline);
+ if (!textMetaContent.Inlines.Any())
MetaIconVisibility = Visibility.Collapsed;
</code_context>
<issue_to_address>
**issue (bug_risk):** `textMetaContent.Inlines.Remove(textMetaContent.Inlines.LastInline)` throws when `Meta.GetExif()` produces no displayable metadata, because `LastInline` is null. Images without EXIF metadata therefore fail while the panel is being constructed instead of simply hiding the metadata icon.
**Triggers:** When the image has no EXIF entries, or all EXIF labels or values are empty.
**Suggested fix:** Only remove the trailing newline when `textMetaContent.Inlines.LastInline` is non-null, or check whether any valid metadata was added before removing it.
```suggestion
if (textMetaContent.Inlines.LastInline != null)
textMetaContent.Inlines.Remove(textMetaContent.Inlines.LastInline);
```
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: QuickLook.Plugin/QuickLook.Plugin.ImageViewer/ImagePanel.xaml.cs:431
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the ImageViewer toolbar tooltips and metadata presentation.
Changes:
Validation:
MinimumRecommendedRules.rulesetis unavailable.Summary by Sourcery
Improve ImageViewer toolbar guidance and image metadata presentation.
New Features:
Bug Fixes:
Enhancements: