Skip to content

fix: Explicitly specify empty_as_null for explode#356

Merged
Oliver Borchert (borchero) merged 2 commits into
mainfrom
fix-nightly
Jun 26, 2026
Merged

fix: Explicitly specify empty_as_null for explode#356
Oliver Borchert (borchero) merged 2 commits into
mainfrom
fix-nightly

Conversation

@borchero

Copy link
Copy Markdown
Member

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a nightly-CI breakage in the experimental schema inference code by making Polars Series.explode behavior explicit during nested-type (List/Array) dtype argument inference.

Changes:

  • Explicitly pass empty_as_null=False to series.explode(...) when inferring inner dtypes for pl.List.
  • Explicitly pass empty_as_null=False to series.explode(...) when inferring inner dtypes for pl.Array (keeping shape=... handling intact).

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (50e18a8) to head (340a1c5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3458      3463    +5     
=========================================
+ Hits          3458      3463    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@borchero

Copy link
Copy Markdown
Member Author

Ah polars-minimal fails. Andreas Albert (@AndreasAlbertQC) should we bump or how should we handle this?

@AndreasAlbertQC

Andreas Albert (AndreasAlbertQC) commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Would be a shame to give up compat with older versions over this. I feel like we just have to bite the bullet and pass / not pass the argument based on polars.__version__

@borchero Oliver Borchert (borchero) enabled auto-merge (squash) June 26, 2026 17:38
@borchero Oliver Borchert (borchero) merged commit 13d9fe2 into main Jun 26, 2026
32 checks passed
@borchero Oliver Borchert (borchero) deleted the fix-nightly branch June 26, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants