[Flydsl] Add Qwen-Image VAE classic conv shapes to conv3d tests - #1069
Draft
huizzhan wants to merge 2 commits into
Draft
[Flydsl] Add Qwen-Image VAE classic conv shapes to conv3d tests#1069huizzhan wants to merge 2 commits into
huizzhan wants to merge 2 commits into
Conversation
Cover T2I T=1 ResBlock 3x3x3 (via 2D weight slice) and Resample downsample cases in both BF16 and FP8 implicit-GEMM conv test suites. Co-authored-by: Cursor <cursoragent@cursor.com>
huizzhan
changed the title
The decoder cases were derived from the config by assuming the channel count keeps halving across up blocks (384 -> 192 -> 96 -> 48). It does not: QwenImageDecoder3d applies in_dim // 2 inside the UpBlock loop, which cancels the halving that upsample2d/3d performs. Forward-hook traces of AutoencoderKLQwenImage show up_blocks.1 running 192->384 then 384->384, up_blocks.2 running 192->192, and up_blocks.3 running 96->96, so dec_d1_res, dec_d2_res and dec_d3_res1 were exercising shapes that never occur in the model. Their real counterparts are already covered by the encoder entries, which is why dropping them loses no coverage; the ids now name both sides. Add the Resample upsample2d/3d convs, which were missing entirely and are the largest real gap: 384->192 @512 and 192->96 @1024 are ~3% of decode MACs each. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conv3d_implicit(BF16) andconv3d_implicit_fp8(FP8) suites.weight[:, :, 2, :, :].Test plan
python -m pytest tests/kernels/test_conv3d_implicit.py -k qwenimage -v(gfx95x)python -m pytest tests/kernels/test_conv3d_implicit_fp8.py -k qwenimage -v(gfx95x)