Skip to content

fix[klibc]: stop gcc from turning the kstring.c byte loops into memset/memcpy calls #11965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rbb666 merged 2 commits into from
Nov 2, 2026
Merged

fix[klibc]: stop gcc from turning the kstring.c byte loops into memset/memcpy calls #11965

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc705ec
fix[klibc]: stop gcc from turning the kstring.c byte loops into memse…
sexenteen Nov 1, 2026
9ceb217
fix[klibc]: do not pass LOCAL_CFLAGS to the clang-analyzer build
sexenteen Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/klibc/SConscript
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from building import *
import os
import rtconfig

cwd = GetCurrentDir()
src = ['kerrno.c', 'kstdio.c', 'kstring.c']
Expand All @@ -13,7 +14,18 @@ if not GetDepend(['RT_KLIBC_USING_LIBC_VSNPRINTF']):
if not GetDepend(['RT_KLIBC_USING_LIBC_VSSCANF']):
src += ['rt_vsscanf.c']

group = DefineGroup('Libc', src, depend = [''])
# at -O2/-Os, GCC recognises the byte loops used by rt_memset()/rt_memcpy()/
# rt_memmove() in kstring.c and turns them into calls to memset()/memcpy()/
# memmove(). Those symbols do not exist on targets built without a C library,
# so the firmware fails to link (see issue #6128). Keep the loops here.
group_args = {'depend': ['']}
if rtconfig.CROSS_TOOL == 'gcc' and not GetOption('clang-analyzer'):
# Do not pass LOCAL_CFLAGS in --clang-analyzer builds: building.py replaces
# CFLAGS with a list there, and local_group() concatenates it with this
# string, which raises TypeError and stops the static analysis.
group_args['LOCAL_CFLAGS'] = ' -fno-tree-loop-distribute-patterns'

group = DefineGroup('Libc', src, **group_args)

list = os.listdir(cwd)
for item in list:
Expand Down
Loading