Repository navigation
Remove canonical vertices, the incidence weld filter and the tree space plane cache - #60
Merged
LogicalError merged 3 commits intoOct 25, 2026
Conversation
…ce plane cache Canonical vertices were an experiment for the old CSG path and never shipped (stage 0, off). Removed with them: the incidence weld filter (also an old path experiment, off), the HashedVertices overloads that took it, and the tree space plane cache, which only those read. The base polygons are built as before: corners as they are, snapped onto the corners of the brushes touching them (the hotspot caps read those corners). Fixes #59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical vertices were an experiment for the old CSG path and never shipped (stage 0, off). Removed with them:
HashedVerticesoverloads that took it,The base polygons are built as before: corners as they are, snapped onto the corners of the brushes touching them (the hotspot caps read those corners, so that stays).
Checked: full suite 1969 of 1969. Three imported maps (266 models) rebuild to the same triangles as main, model for model, with no errors or warnings.
Fixes #59